chore: remove unused container-azm-ms-osmconfig ConfigMap#1700
Open
zanejohnson-azure wants to merge 1 commit into
Open
chore: remove unused container-azm-ms-osmconfig ConfigMap#1700zanejohnson-azure wants to merge 1 commit into
zanejohnson-azure wants to merge 1 commit into
Conversation
OSM (Open Service Mesh) scraping support in ama-logs is unused. Telemetry over the last 30 days shows 33 clusters with the ConfigMap mounted but zero with osmNamespaceCount > 0 (no cluster has any monitor_namespaces configured). OSM itself was archived by CNCF in early 2024. This commit removes the sample ConfigMap manifest as a first step toward deprecating OSM support. Code paths in the agent (tomlparser-osm-config.rb, in_kube_nodes.rb, telemetry.go, telegraf configs, Helm volume mounts) are left in place and can be removed in a follow-up. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
kubernetes/container-azm-ms-osmconfig.yaml— the sample ConfigMap used to enable Open Service Mesh (OSM) Prometheus scraping by ama-logs.Why
OSM scraping support in ama-logs is effectively unused. Telemetry from the last 30 days:
container-azm-ms-osmconfigConfigMap appliedosmNamespaceCount > 0)Query used (against the Container Insights agent App Insights):
Every cluster that has the ConfigMap mounted has
monitor_namespacesempty — no one is actually using the feature. Additionally, OSM was archived by CNCF in early 2024.Scope
This PR only removes the sample ConfigMap manifest as a first deprecation step. The agent code paths that read it are left in place for now and can be removed in a follow-up:
build/linux/installer/scripts/tomlparser-osm-config.rbsource/plugins/ruby/in_kube_nodes.rbandsource/plugins/go/src/telemetry.go$AZMON_TELEGRAF_OSM_PROM_PLUGINSplaceholders inbuild/linux/installer/conf/telegraf-*.confcontainer-azm-ms-osmconfigincharts/azuremonitor-containers*/templates/Documentation/OSMPrivatePreview/Risk
Low — this file is a sample manifest. Removing it doesn't affect any cluster where it has already been applied (the ConfigMap continues to exist on those clusters until explicitly deleted). It just stops shipping the template in the repo.