Add two missing CI features#1272
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI feature set to cover recently added diskann-benchmark feature-gated benchmarks, and refactors BfTree streaming benchmark function signatures to satisfy clippy lints now that clippy runs on that code.
Changes:
- Add
multi-vectorandbftreeto theDISKANN_FEATURESlist used by CI and nightly clippy/test jobs. - Introduce local type aliases to simplify complex tuple return types in BfTree streaming benchmark helpers (clippy
type_complexitymitigation).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
diskann-benchmark/src/index/bftree/spherical_streaming.rs |
Adds a tuple type alias and uses it as the helper return type to reduce signature complexity. |
diskann-benchmark/src/index/bftree/full_precision_streaming.rs |
Adds a generic tuple type alias and uses it as the helper return type to reduce signature complexity. |
.github/workflows/nightly.yml |
Adds multi-vector and bftree to the feature list exercised by nightly jobs. |
.github/workflows/ci.yml |
Adds multi-vector and bftree to the feature list exercised by PR CI jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1272 +/- ##
==========================================
- Coverage 91.50% 90.47% -1.03%
==========================================
Files 498 498
Lines 95522 95522
==========================================
- Hits 87408 86427 -981
- Misses 8114 9095 +981
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
harsha-simhadri
approved these changes
Jul 23, 2026
arkrishn94
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These features correspond to two recently added entries in
diskann-benchmarkthat missed updating the CI feature set. The type aliases in thediskann-benchmark/src/index/bftree/*are in response to clippy lints now running on that code.