[HLSL] Add larger-shape LinAlg arithmetic and transfer coverage - #8939
Open
Jack Elliott (JoeCitizen) wants to merge 1 commit into
Open
Jack Elliott (JoeCitizen) wants to merge 1 commit into
Jack Elliott (JoeCitizen) wants to merge 1 commit into
Conversation
Add six capability-gated companions while retaining the smaller fixtures: - 16x32x16 signed-I8 groupshared MMA with an I32 accumulator. - 16x32x16 non-uniform FP16 multiply to FP16 and FP32. - 16x32x16 FP16-to-FP32 MMA with independent non-zero accumulation. - 16x32 FP16 accumulation from a B-use matrix. - Rectangular, wave-scaled FP16 ThreadGroup groupshared transfer. Reuse the existing fixtures and independent CPU oracles. The ThreadGroup transfer uses two waves and checks its full padded groupshared footprint, requesting an extended shader limit only when the device supports it. Refs microsoft#7841 Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 333cb159-4a7f-458d-92d5-ac330c55edee
Jack Elliott (JoeCitizen)
marked this pull request as ready for review
September 21, 2026 22:47
Copilot started reviewing on behalf of
Jack Elliott (JoeCitizen)
September 21, 2026 22:48
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The test-only changes are capability-gated, preserve existing fixtures, and correctly exercise asymmetric larger shapes.
Review effort: Balanced
Findings: None
What changed in this PR
Expands HLSL linear-algebra execution coverage with larger matrix shapes while preserving capability gating.
Changes:
- Adds larger 16-row arithmetic and memory test variants.
- Adds wave-scaled thread-group transfer coverage, including extended groupshared limits.
- Refactors shared test setup to parameterize matrix dimensions.
| File | Description |
|---|---|
tools/clang/unittests/HLSLExec/LinAlgTests.cpp |
Adds and parameterizes larger-shape LinAlg execution tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds six larger-shape companions without removing the smaller fixtures or changing capability policy:
MatMatMulAccumMemory_Wave_16x32x16_I8_ToI32_OffsetPaddedMatMatMul_Wave_16x32x16_F16_NonUniformMatMatMul_Wave_16x32x16_F16_ToF32MatMatMulAccum_Wave_16x32x16_F16_ToF32_NonUniformMatAccum_Wave_16x32_F16_BUse_NonUniformLoadStoreMemory_ThreadGroup_WaveScaled_F16Refs #7841
Assisted-by: GitHub Copilot