Skip to content

[SPIRV] Legalize OpCopyLogical of OpCompositeConstruct - #8541

Closed
Steve Urquhart (SteveUrquhart) wants to merge 1 commit into
microsoft:mainfrom
SteveUrquhart:fold-copylogical-of-composite
Closed

Steve Urquhart (SteveUrquhart) wants to merge 1 commit into
microsoft:mainfrom
SteveUrquhart:fold-copylogical-of-composite

Conversation

@SteveUrquhart

Copy link
Copy Markdown
Contributor

This PR accommodates a fix to the optimizer in KhronosGroup/SPIRV-Tools#6746. We can see that the test was checking for artifacts that are now optimized away. This is an improvement and the new test shown here reflects that.

It doesn't appear that commits combine SPIRV-TOOLS submodule updates like this one. But I wanted to publish the test that will be required when KhronosGroup/SPIRV-Tools#6746 merges.

@dnovillo

Copy link
Copy Markdown
Collaborator

Steve Urquhart (@SteveUrquhart) do you still need this? It doesn't seem necessary anymore.

@SteveUrquhart

Copy link
Copy Markdown
Contributor Author

Hi Diego Novillo (@dnovillo), if dxc is now incorporating KhronosGroup/SPIRV-Tools#6746 and changes to this test were not required, then I'm surprised. Maybe someone else made them. This was a Draft and we can delete if if it's not necessary. My other 3 currently open are in a finished state...

@dnovillo

Copy link
Copy Markdown
Collaborator

Hi Diego Novillo (Diego Novillo (@dnovillo)), if dxc is now incorporating KhronosGroup/SPIRV-Tools#6746 and changes to this test were not required, then I'm surprised. Maybe someone else made them. This was a Draft and we can delete if if it's not necessary. My other 3 currently open are in a finished state...

OK, thanks. I was curious because this is still in Draft and it's trying to pin to a tip of SPIRV-Tools that's older than what we have currently (#8738).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spirv Work related to SPIR-V

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants