[SPIRV] Legalize OpCopyLogical of OpCompositeConstruct - #8541
Steve Urquhart (SteveUrquhart) wants to merge 1 commit into
Conversation
|
Steve Urquhart (@SteveUrquhart) do you still need this? It doesn't seem necessary anymore. |
|
Hi Diego Novillo (@dnovillo), if dxc is now incorporating KhronosGroup/SPIRV-Tools#6746 and changes to this test were not required, then I'm surprised. Maybe someone else made them. This was a Draft and we can delete if if it's not necessary. My other 3 currently open are in a finished state... |
OK, thanks. I was curious because this is still in Draft and it's trying to pin to a tip of SPIRV-Tools that's older than what we have currently (#8738). |
This PR accommodates a fix to the optimizer in KhronosGroup/SPIRV-Tools#6746. We can see that the test was checking for artifacts that are now optimized away. This is an improvement and the new test shown here reflects that.
It doesn't appear that commits combine SPIRV-TOOLS submodule updates like this one. But I wanted to publish the test that will be required when KhronosGroup/SPIRV-Tools#6746 merges.