Skip to content

Fix out-of-bounds reads in Validate()'s bow-tie and adjacency checks #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Roland Shum (ShumWengSang) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix out-of-bounds reads in Validate()'s bow-tie and adjacency checks #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion DirectXMesh/DirectXMeshValidate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,11 @@ namespace
if (k == UNUSED32)
continue;

assert(k < nFaces);
if (k >= nFaces)
{
result = false;
continue;
}

const uint32_t edge = find_edge<uint32_t>(&adjacency[k * 3], uint32_t(face));
if (edge >= 3)
Expand Down Expand Up @@ -331,6 +335,8 @@ namespace
faceSeen[curFace * 3 + curPoint] = true;

uint32_t j = indices[curFace * 3 + curPoint];
if (j == index_t(-1))
continue;

if (faceIds[j] == index_t(-1))
{
Expand Down
Loading