Bound restart acknowledgement waits and bump extension to 2.4.2 - #163
Merged
Merged
Conversation
Mitigate #160 without treating target stop events as restart acknowledgement. Preserve adapter errors and document Cortex-Debug's missing-response behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e8c76249-e4b9-47a4-adee-0ef91ec3f978
✅ Extension Build Successful!📦 VSIX artifact is ready for download Scroll down to the "Artifacts" section and download To install: In VS Code, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause and scope
Related to #160.
Cortex-Debug v1.12.1 advertises DAP restart support, but its successful restart handler resolves an internal promise without sending the DAP response. The target can reset and emit continued/stopped events while VS Code's restart command remains pending. Its error branch does send a response.
This PR is a client-side safeguard, not a repair of that upstream omission. It deliberately does not interpret an arbitrary stop event as successful restart completion, bypass VS Code's restart lifecycle, or automatically tear down an embedded session. The reporter's exact Cortex-Debug version and DAP trace still need confirmation; newer upstream Cortex-Debug uses a different teardown/relaunch path. This PR therefore does not automatically close #160.
Validation