Skip to content

Test forced snapshots while service is opening#8090

Open
achamayou wants to merge 4 commits into
mainfrom
achamayou-test-opening-state-snapshot
Open

Test forced snapshots while service is opening#8090
achamayou wants to merge 4 commits into
mainfrom
achamayou-test-opening-state-snapshot

Conversation

@achamayou

Copy link
Copy Markdown
Member

Summary

  • add an e2e regression test that leaves the service in Opening
  • accept trigger_snapshot through governance and advance commits with governance transactions
  • require both the snapshot and its ledger chunk to be committed on disk

Testing

  • python -m black --check tests/e2e_operations.py
  • python -m ruff check tests/e2e_operations.py
  • python -m py_compile tests/e2e_operations.py

Closes #6469

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 753b9200-3eac-4654-9471-494c6e4c039b
Comment thread tests/e2e_operations.py
…test

Co-authored-by: eddyashton <6000239+eddyashton@users.noreply.github.com>
Copilot AI requested a review from eddyashton July 23, 2026 14:46
@achamayou
achamayou marked this pull request as ready for review July 23, 2026 15:12
@achamayou
achamayou requested a review from a team as a code owner July 23, 2026 15:12
Copilot AI review requested due to automatic review settings July 23, 2026 15:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an end-to-end regression test to ensure that forcing a snapshot via governance while the service remains in Opening results in both (a) a committed snapshot file and (b) a committed ledger chunk containing that snapshot—covering the failure described in #6469.

Changes:

  • Add test_forced_snapshot_while_opening which triggers a snapshot via governance while the service is still Opening, then verifies the snapshot exists and the containing ledger chunk is committed/complete.
  • Add a dedicated runner (run_forced_snapshot_while_opening) that starts a network without opening it, executes the regression test, and is invoked from run().

Custom instructions used:

  • .github/copilot-instructions.md
  • .github/instructions/reviewing.instructions.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggering snapshots while network is in opening state results in no .committed files

4 participants