Test forced snapshots while service is opening#8090
Open
achamayou wants to merge 4 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 753b9200-3eac-4654-9471-494c6e4c039b
eddyashton
reviewed
Jul 23, 2026
…test Co-authored-by: eddyashton <6000239+eddyashton@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an end-to-end regression test to ensure that forcing a snapshot via governance while the service remains in Opening results in both (a) a committed snapshot file and (b) a committed ledger chunk containing that snapshot—covering the failure described in #6469.
Changes:
- Add
test_forced_snapshot_while_openingwhich triggers a snapshot via governance while the service is stillOpening, then verifies the snapshot exists and the containing ledger chunk is committed/complete. - Add a dedicated runner (
run_forced_snapshot_while_opening) that starts a network without opening it, executes the regression test, and is invoked fromrun().
Custom instructions used:
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Openingtrigger_snapshotthrough governance and advance commits with governance transactionsTesting
python -m black --check tests/e2e_operations.pypython -m ruff check tests/e2e_operations.pypython -m py_compile tests/e2e_operations.pyCloses #6469