start_in_recovery(..., from_network=#8048
Draft
cjen1-msft wants to merge 1 commit into
Draft
Conversation
Add a from_network argument to Network.start_in_recovery so a recovered network can be seeded from a whole previous network - each node from its own disk, selected round-robin - rather than from a single ledger/snapshot set. Node 0 is recovered and the other nodes join it, closer to a production disaster recovery where every node has its own persistent disk. Also add an expected-failure e2e test (recovery_from_network) which stops nodes one by one so their per-node snapshots diverge, and asserts that recovery currently fails to start under that divergence. This reproduces a known snapshot-divergence issue and must be updated once it is handled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when we start in recovery we pass a ledger and snapshot directory.
We then:
This means we are not testing divergent snapshots in our CI currently.
This PR somewhat addresses that by providing a
from_networkargument to start_in_recovery which maps each node in the recovery network to a node in the original network via round-robin and then recovers using that.Two issues its highlighted, but I haven't yet dug into
Why does the test currently fail as it is doing nothing?
If the network was stable when it was stopped, I'd expect the recovery to be fine, but I think its because we immediately after opening shut down the network.