Skip to content

Use optional chaining for getter access #5729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compulim merged 3 commits into from
Mar 6, 2026
+1 −1
Merged

Use optional chaining for getter access #5729

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c823861
Use optional chaining for getter access
pranavjoshi001 Feb 19, 2026
d358d0e
Merge branch 'main' into directline-null-check-capabilities
pranavjoshi001 Mar 4, 2026
097baad
Merge branch 'main' into directline-null-check-capabilities
compulim Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/api/src/providers/Capabilities/private/fetchCapabilitiesFromAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default function fetchCapabilitiesFromAdapter(
}

// eslint-disable-next-line security/detect-object-injection
const getter = directLine[getterName];
const getter = directLine?.[getterName];
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optional chaining is a good defensive fix, but the function's type signature on line 16 still declares directLine: DirectLineJSBotConnection (non-nullable). This means TypeScript won't flag callers that pass a non-null value, and the optional chaining here will appear unnecessary to anyone reading the types. Consider updating the parameter type to directLine: DirectLineJSBotConnection | undefined (or directLine?: DirectLineJSBotConnection) so that the type signature accurately reflects that directLine may be nullish. This also aligns with WebChatAPIContext.ts line 31 where directLine is already typed as optional.

Copilot uses AI. Check for mistakes.

if (typeof getter === 'function') {
try {
Expand Down
Loading