This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: [#8576] Field loses focus after keystroke#9509
Open
ceciliaavila wants to merge 3 commits intomainfrom
Open
fix: [#8576] Field loses focus after keystroke#9509ceciliaavila wants to merge 3 commits intomainfrom
ceciliaavila wants to merge 3 commits intomainfrom
Conversation
OEvgeny
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with the lost focus on the Prompt action's text fields after the first keystroke.
The NodeWrapper component has a condition that evaluates the selected nodes, and tabs to decide if the focus() function should be called. In the re-render of the component, this condition was evaluated as true when it shouldn't, causing an unnecessary re-focus.
We updated the flags used in this condition to call the focus() function only when the tab and the node are selected.
Task Item
Fixes #8576
Screenshots
Here we can see the focus working as expected in the Prompt action after the changes.
