Skip to content

Fix AA0217 in BCPT Setup Card test and build System App Modules under strict ruleset #9685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aholstrup1 merged 3 commits into from
Jul 23, 2026
+17 −3
Merged

Fix AA0217 in BCPT Setup Card test and build System App Modules under strict ruleset #9685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8adb951
Fix AA0217 in BCPT Setup Card test and build System App Modules apps …
aholstrup1 Jul 23, 2026
44aa0ab
Skip execute-permissions verification for src/Tools apps
aholstrup1 Jul 23, 2026
17a44d1
Build Tools apps as test-type instead of skipping permission check
aholstrup1 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions build/projects/System Application Modules/.AL-Go/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,26 @@
"projectName": "System Application Modules",
"appFolders": [
"../../../src/System Application/App/*",
"../../../src/Business Foundation/App/*"
"../../../src/System Application/App",
"../../../src/Business Foundation/App/*",
"../../../src/Business Foundation/App"
],
"testFolders": [
"../../../src/System Application/Test/*",
"../../../src/System Application/Test Library/*",
"../../../src/System Application/Test",
"../../../src/System Application/Test Library",
"../../../src/System Application/Partner Test",
"../../../src/System Application/Partner Test/AI",
"../../../src/Business Foundation/Test/*",
"../../../src/Business Foundation/Test Library/*"
"../../../src/Business Foundation/Test Library/*",
"../../../src/Business Foundation/Test",
"../../../src/Business Foundation/Test Library",
"../../../src/Tools/Performance Toolkit/App",
"../../../src/Tools/Performance Toolkit/Test",
"../../../src/Tools/AI Test Toolkit",
"../../../src/Tools/Test Framework/Test Libraries/*",
"../../../src/Tools/Test Framework/*"
],
"doNotPublishApps": true,
"rulesetFile": "../../../src/rulesets/internal.module.ruleset.json",
Expand Down
3 changes: 2 additions & 1 deletion src/Tools/Performance Toolkit/Test/src/BCPTSetupCardTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ codeunit 144741 "BCPT Setup Card Test"
BCPTSetupCard: TestPage "BCPT Setup Card";
ActualNoOfIterations: Integer;
UnexpectedNoOfSqlStmtsLbl: Label 'Unexpected value in %1. Expected %2, Actual %3', Locked = true;
OrValueLbl: Label '%1 or %2', Locked = true;
Comment thread
aholstrup1 marked this conversation as resolved.
begin
Initialize();

Expand All @@ -152,7 +153,7 @@ codeunit 144741 "BCPT Setup Card Test"
// counts 2 extra SQL statements from system tables. Therefore the total is either ActualNoOfIterations or ActualNoOfIterations + 2.
Assert.IsTrue(
BCPTSetupCard.BCPTLines.NoOfSQLStmts.AsInteger() in [ActualNoOfIterations, ActualNoOfIterations + 2],
StrSubstNo(UnexpectedNoOfSqlStmtsLbl, BCPTLogEntry.FieldCaption("No. of SQL Statements"), StrSubstNo('%1 or %2', ActualNoOfIterations, ActualNoOfIterations + 2), BCPTSetupCard.BCPTLines.NoOfSQLStmts.AsInteger()));
StrSubstNo(UnexpectedNoOfSqlStmtsLbl, BCPTLogEntry.FieldCaption("No. of SQL Statements"), StrSubstNo(OrValueLbl, ActualNoOfIterations, ActualNoOfIterations + 2), BCPTSetupCard.BCPTLines.NoOfSQLStmts.AsInteger()));
BCPTSetupCard.BCPTLines.AvgSQLStmts.AssertEquals(1);
BCPTSetupCard.Close();
end;
Expand Down
Loading