Skip to content

Stabilize partial sales shipment undo test#9672

Open
attilatoury wants to merge 1 commit into
mainfrom
private/attilatoury/fix-640085-test-stability-main
Open

Stabilize partial sales shipment undo test#9672
attilatoury wants to merge 1 commit into
mainfrom
private/attilatoury/fix-640085-test-stability-main

Conversation

@attilatoury

@attilatoury attilatoury commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Problem

UndoSalesShipmentLinePartialWithAsmItemLotAndItemtrackingSerial uses 100 serial-tracked units and a random shipment divisor. This adds unnecessary warehouse activity and can make the supposed partial shipment a full shipment.

Fix

Reduce the quantity to 10 and deterministically ship half. This keeps multiple serial numbers, guarantees a partial shipment, and removes accidental stress and randomness.

This ports the stabilization for ADO 640085 to BCApps main. Release ports are NAV PRs 251310 and 251313.

Validation

  • git diff --check passed.
  • No editor diagnostics in the changed AL file.
  • Full local compilation remains blocked by unavailable matching reference dependencies.

Risk

Low. Only test data is changed; product code is unaffected.

Fixes AB#640085

@attilatoury
attilatoury requested a review from a team July 22, 2026 15:06
@github-actions github-actions Bot added the SCM GitHub request for SCM area label Jul 22, 2026
Comment thread src/Layers/W1/Tests/SCM/SCMWarehouseShippingIII.Codeunit.al
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 23, 2026

@qasimikram qasimikram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixed quantities guarantee a genuine partial shipment while preserving the original posting, undo, bin-inventory, and positive-adjustment assertions. This removes the nondeterministic full-shipment case without weakening the scenario.

Recommendation: Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants