Stabilize partial sales shipment undo test#9672
Open
attilatoury wants to merge 1 commit into
Open
Conversation
JakovljevicDusan
approved these changes
Jul 23, 2026
qasimikram
approved these changes
Jul 23, 2026
qasimikram
left a comment
Contributor
There was a problem hiding this comment.
The fixed quantities guarantee a genuine partial shipment while preserving the original posting, undo, bin-inventory, and positive-adjustment assertions. This removes the nondeterministic full-shipment case without weakening the scenario.
Recommendation: Approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
UndoSalesShipmentLinePartialWithAsmItemLotAndItemtrackingSerialuses 100 serial-tracked units and a random shipment divisor. This adds unnecessary warehouse activity and can make the supposed partial shipment a full shipment.Fix
Reduce the quantity to 10 and deterministically ship half. This keeps multiple serial numbers, guarantees a partial shipment, and removes accidental stress and randomness.
This ports the stabilization for ADO 640085 to BCApps main. Release ports are NAV PRs 251310 and 251313.
Validation
git diff --checkpassed.Risk
Low. Only test data is changed; product code is unaffected.
Fixes AB#640085