Stabilize planning order tracking test dates#9671
Open
attilatoury wants to merge 1 commit into
Open
Conversation
JakovljevicDusan
approved these changes
Jul 23, 2026
qasimikram
reviewed
Jul 23, 2026
| // [FEATURE] [PlanningWorksheet] [Requisition Line] [Item] [Reordering Policy] | ||
| // [SCENARIO 478131] Lot By Lot Item planing with specific quantity and date combination should lead to canceled status of 2 requisition lines. | ||
| Initialize(); | ||
| ScenarioYear := Date2DMY(WorkDate(), 3) + 1; |
Contributor
There was a problem hiding this comment.
S1 (non-blocking): Please consider exercising this scenario with early- and late-year WorkDate values and re-enabling the disabled test. The next-year dates and fixed planning horizon preserve the scenario intent; boundary execution would provide useful runtime proof.
qasimikram
approved these changes
Jul 23, 2026
qasimikram
left a comment
qasimikram
left a comment
Contributor
There was a problem hiding this comment.
Using a single next-year ScenarioYear makes the dates deterministic while preserving event ordering, quantities, and the planning horizon. The change removes calendar-year drift without weakening the assertions or appearing to mask a production defect.
S1 is a non-blocking suggestion for boundary execution and re-enabling the disabled scenario.
Recommendation: Approve with Suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CheckLotForLotItemPlanningWorksheetActionchanges behavior asWorkDateadvances through its fixed month/day scenario.Root cause
Supply and demand dates used the current calendar year, so scenario events could become overdue while the assertion continued to expect two cancellation lines.
Fix
Place the scenario in the next calendar year and align the regenerative planning horizon with that year. Product behavior is unchanged.
The test remains in the existing disabled-test manifest; this PR deliberately does not change broader test enablement policy.
Validation
git diff --check: cleanRelated work item: ADO 641448
Fixes AB#641448