Skip to content

Enable RU tests#9576

Open
spetersenms wants to merge 4 commits into
mainfrom
spetersen/RUTests
Open

Enable RU tests#9576
spetersenms wants to merge 4 commits into
mainfrom
spetersen/RUTests

Conversation

@spetersenms

@spetersenms spetersenms commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Enables RU tests.

AB#642528

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

@spetersenms
spetersenms requested review from a team July 17, 2026 10:46
@github-actions github-actions Bot added Build: scripts & configs Build scripts and configuration files Finance GitHub request for Finance area labels Jul 17, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 17, 2026
Comment thread src/Layers/RU/Tests/Local/RUReportDownloadHandler.Codeunit.al
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain Findings Knowledge-backed Agent Inline Fallback
Agent 1 0 1 0 0
Events 1 1 0 1 0

Totals: 1 knowledge-backed · 1 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

@JesperSchulz JesperSchulz added Other GitHub request for other area than SCM, Finance or Integration Ownership: Manual Preserve the manually selected team ownership and removed Finance GitHub request for Finance area labels Jul 17, 2026
@spetersenms
spetersenms requested a review from a team July 20, 2026 08:52
Comment thread src/Layers/RU/Tests/Local/RUReportDownloadHandler.Codeunit.al
Comment thread src/DisabledTests/Tests-ERM/Tests-ERM.DisabledTest.json
@spetersenms
spetersenms enabled auto-merge July 22, 2026 11:44
These two tests (AdjustCostForDifferentCurrencyExchangeRate,
PostPurchOrderWithDiffCurrencyExchangeRate) fail in the RU build due to
#9071's ACY balancing change in RU Purch.-Post. They are already disabled
in NAV (App/DisabledTests/SCMInventoryCostingIV.DisabledTest.json, PR 250996).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
{
"codeunitId": 134812,
"codeunitName": "ERM CA GL Transfer",
"method": "GLTransferWithClosingDate",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Agent}$

Tests-Cost_Accounting.DisabledTest.json disables 'ERM CA GL Transfer'.GLTransferWithClosingDate and then the entire codeunit (method: "*") with a bug note stating the shared W1 test 'runs+passes for W1/other countries' and only fails 'under RU base-app behavior in the merged RU build'. That is evidence the RU layer merge changed shared/base-app behavior that this test was verifying, and the fix taken is to permanently silence the regression signal for every country's pipeline rather than only for the RU project or the underlying behavioral discrepancy. If the impact would otherwise be treated as major/blocker (loss of shared regression coverage triggered by a real behavioral change), it is being capped at minor here per policy for agent-only findings; a knowledgeable reviewer should confirm whether the RU-induced behavior change is itself a defect before accepting a global, permanent disable.

Recommendation:

  • scope the disable to the RU pipeline only (if the disable mechanism supports per-project scoping) or file and link an issue tracking the root-cause behavioral discrepancy instead of a blanket global disable.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.15.4

{
"codeunitId": 134911,
"codeunitName": "ERM Create Finance Charge Memo",
"method": "SuggestFinanceChargeMemo",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Agent}$

Tests-ERM.DisabledTest.json disables 'ERM Create Finance Charge Memo'.SuggestFinanceChargeMemo and SuggestFinanceChargeMemoLine with the same bug note pattern: the shared W1 test 'runs+passes for W1/other countries' and only fails 'under RU base-app behavior in the merged RU build', yet both are 'Disabled globally'. This permanently removes regression coverage for a shared, non-RU-specific test codeunit for every country's build to unblock the RU pipeline, rather than scoping the disable to RU or addressing the underlying behavioral change the RU merge introduced. Severity is capped at minor per the agent-finding policy, but the underlying risk (an unreviewed base-app behavior change surfaced only by disabling the test that caught it) warrants follow-up before merge.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.15.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build: scripts & configs Build scripts and configuration files Other GitHub request for other area than SCM, Finance or Integration Ownership: Manual Preserve the manually selected team ownership

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants