Enable RU tests#9576
Conversation
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf Findings by domainFindings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).
Totals: 1 knowledge-backed · 1 agent findings. Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives. |
These two tests (AdjustCostForDifferentCurrencyExchangeRate, PostPurchOrderWithDiffCurrencyExchangeRate) fail in the RU build due to #9071's ACY balancing change in RU Purch.-Post. They are already disabled in NAV (App/DisabledTests/SCMInventoryCostingIV.DisabledTest.json, PR 250996). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
| { | ||
| "codeunitId": 134812, | ||
| "codeunitName": "ERM CA GL Transfer", | ||
| "method": "GLTransferWithClosingDate", |
There was a problem hiding this comment.
Tests-Cost_Accounting.DisabledTest.json disables 'ERM CA GL Transfer'.GLTransferWithClosingDate and then the entire codeunit (method: "*") with a bug note stating the shared W1 test 'runs+passes for W1/other countries' and only fails 'under RU base-app behavior in the merged RU build'. That is evidence the RU layer merge changed shared/base-app behavior that this test was verifying, and the fix taken is to permanently silence the regression signal for every country's pipeline rather than only for the RU project or the underlying behavioral discrepancy. If the impact would otherwise be treated as major/blocker (loss of shared regression coverage triggered by a real behavioral change), it is being capped at minor here per policy for agent-only findings; a knowledgeable reviewer should confirm whether the RU-induced behavior change is itself a defect before accepting a global, permanent disable.
Recommendation:
- scope the disable to the RU pipeline only (if the disable mechanism supports per-project scoping) or file and link an issue tracking the root-cause behavioral discrepancy instead of a blanket global disable.
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.15.4
| { | ||
| "codeunitId": 134911, | ||
| "codeunitName": "ERM Create Finance Charge Memo", | ||
| "method": "SuggestFinanceChargeMemo", |
There was a problem hiding this comment.
Tests-ERM.DisabledTest.json disables 'ERM Create Finance Charge Memo'.SuggestFinanceChargeMemo and SuggestFinanceChargeMemoLine with the same bug note pattern: the shared W1 test 'runs+passes for W1/other countries' and only fails 'under RU base-app behavior in the merged RU build', yet both are 'Disabled globally'. This permanently removes regression coverage for a shared, non-RU-specific test codeunit for every country's build to unblock the RU pipeline, rather than scoping the disable to RU or addressing the underlying behavioral change the RU merge introduced. Severity is capped at minor per the agent-finding policy, but the underlying risk (an unreviewed base-app behavior change surfaced only by disabling the test that caught it) warrants follow-up before merge.
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.15.4
Enables RU tests.
AB#642528
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility