Skip to content

[Extensibility Request] issue 30336: add OnValidateNoOnBeforeModifyCapNeedEntries event in Prod. Order Routing Line#9463

Open
AleksandricMarko wants to merge 2 commits into
mainfrom
ai-ext-fix/ext_issue-30336
Open

[Extensibility Request] issue 30336: add OnValidateNoOnBeforeModifyCapNeedEntries event in Prod. Order Routing Line#9463
AleksandricMarko wants to merge 2 commits into
mainfrom
ai-ext-fix/ext_issue-30336

Conversation

@AleksandricMarko

@AleksandricMarko AleksandricMarko commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

The issue author is building a customization on table 5409 "Prod. Order Routing Line" that must run after the standard Work Center / Machine Center transfer logic populates the routing line, but before capacity need entries are updated. They need access to both Rec and xRec to compare the previous and current routing line state at that exact point, which no existing event provides. This PR adds an integration event at that precise location so extensions can subscribe without duplicating validation logic.

Source issue repository: microsoft/AlAppExtensions; issue number: 30336

Changes Made

  • Prod. Order Routing Line (table 5409) - Added integration event OnValidateNoOnBeforeModifyCapNeedEntries(Rec, xRec) in the OnValidate trigger of field No., raised after WorkCenterTransferFields()/MachineCtrTransferFields() and immediately before ModifyCapNeedEntries(); new publisher declared alongside the other integration events. The same change is mirrored in the IT layer counterpart.

Fixes AB#641735

…nt in Prod. Order Routing Line

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@AleksandricMarko AleksandricMarko added event-request SCM GitHub request for SCM area labels Jul 15, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 15, 2026
@AleksandricMarko
AleksandricMarko marked this pull request as ready for review July 16, 2026 07:56
@AleksandricMarko
AleksandricMarko requested a review from a team July 16, 2026 07:56
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

All 16 sub-skills completed or reported no applicable knowledge for this diff. al-events-review evaluated 12 relevant articles against the new IntegrationEvent publisher with no violations. Self-review pass found no cross-cutting defects.

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

6CRIPT
6CRIPT previously approved these changes Jul 17, 2026

@6CRIPT 6CRIPT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep xRex without "var" instead? The OP suggested so in microsoft/ALAppExtensions#30336

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.


🔄 How to trigger a new status check:

  1. 📤 Push a new commit to the PR branch, or
  2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

PredragMaricic
PredragMaricic previously approved these changes Jul 20, 2026

@qasimikram qasimikram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S1: Remove var from xProdOrderRoutingLine in both publisher declarations. The linked request needs the previous value for comparison, not mutation. With the current signature, a subscriber can change xRec before the subsequent (xRec."No." <> '') condition and unintentionally alter whether CalcStartingEndingDates runs.

@AleksandricMarko

Copy link
Copy Markdown
Contributor Author

@copilot please remove var for xProdOrderRoutingLine parameter in both files

Copilot AI dismissed stale reviews from PredragMaricic and 6CRIPT via b2b8d46 July 23, 2026 16:40

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@copilot please remove var for xProdOrderRoutingLine parameter in both files

Done in commit b2b8d46 — removed var from xProdOrderRoutingLine in both W1 and IT publisher declarations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

event-request SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants