[Extensibility Request] issue 30336: add OnValidateNoOnBeforeModifyCapNeedEntries event in Prod. Order Routing Line#9463
Conversation
…nt in Prod. Order Routing Line Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot PR ReviewIteration 1 · Outcome: completed
Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives. |
6CRIPT
left a comment
There was a problem hiding this comment.
Should we keep xRex without "var" instead? The OP suggested so in microsoft/ALAppExtensions#30336
|
qasimikram
left a comment
There was a problem hiding this comment.
S1: Remove var from xProdOrderRoutingLine in both publisher declarations. The linked request needs the previous value for comparison, not mutation. With the current signature, a subscriber can change xRec before the subsequent (xRec."No." <> '') condition and unintentionally alter whether CalcStartingEndingDates runs.
|
@copilot please remove var for xProdOrderRoutingLine parameter in both files |
Summary
The issue author is building a customization on table 5409 "Prod. Order Routing Line" that must run after the standard Work Center / Machine Center transfer logic populates the routing line, but before capacity need entries are updated. They need access to both
RecandxRecto compare the previous and current routing line state at that exact point, which no existing event provides. This PR adds an integration event at that precise location so extensions can subscribe without duplicating validation logic.Source issue repository: microsoft/AlAppExtensions; issue number: 30336
Changes Made
Prod. Order Routing Line(table 5409) - Added integration eventOnValidateNoOnBeforeModifyCapNeedEntries(Rec, xRec)in theOnValidatetrigger of fieldNo., raised afterWorkCenterTransferFields()/MachineCtrTransferFields()and immediately beforeModifyCapNeedEntries(); new publisher declared alongside the other integration events. The same change is mirrored in the IT layer counterpart.Fixes AB#641735