[Extensibility Request] issue 30290: Add OnBeforeUpdateSetupOnBillToCustomerChangeInSalesHeader event#9450
[Extensibility Request] issue 30290: Add OnBeforeUpdateSetupOnBillToCustomerChangeInSalesHeader event#9450AleksandricMarko wants to merge 1 commit into
Conversation
…alesHeader event Add an IsHandled integration event before the AltCustVATRegFacade VAT registration setup call in SetBillToCustomerAddressFieldsFromCustomer so subscribers can skip the standard logic. Propagated across all layers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives. |
|
qasimikram
left a comment
qasimikram
left a comment
There was a problem hiding this comment.
The event is narrowly scoped around the requested VAT registration setup update and is propagated consistently across the country-layer copies.
S1: Please add regression coverage for both branches. Verify that the standard facade update remains effective when unhandled and that a handled subscriber's custom VAT registration and posting setup is not overwritten by the standard call.
3 participants
Summary
The issue author has a separate extension that already handles assignment of the VAT Registration No. and related posting groups when the bill-to customer changes on a sales header. Because
SetBillToCustomerAddressFieldsFromCustomeralways callsAltCustVATRegFacade.UpdateSetupOnBillToCustomerChangeInSalesHeader, the standard logic can overwrite or conflict with the values set by their feature. This PR adds anIsHandledintegration event so subscribers can skip that specific call while leaving the rest of the standard logic intact.Source issue repository: microsoft/AlAppExtensions; issue number: 30290
Changes Made
OnBeforeUpdateSetupOnBillToCustomerChangeInSalesHeader- NewIntegrationEventraised in theSetBillToCustomerAddressFieldsFromCustomerprocedure of tableSales Header, right before theAltCustVATRegFacade.UpdateSetupOnBillToCustomerChangeInSalesHeadercall.IsHandledis initialized tofalseand, when a subscriber sets it totrue, the standard call is skipped. The same change was propagated to every layer that has its own copy of the file.Fixes AB#641535