[Extensibility Request] issue 30264: add and extend events in CalcBestDirectUnitCost

[AleksandricMarko]

Summary

The author needs to customize purchase price selection in CalcBestDirectUnitCost (codeunit 7010 "Purch. Price Calc. Mgt.") on a per-price-record basis - deciding which quantity the minimum-quantity check compares against, applying a different best-price selection rule, and intercepting the no-price fallback cost. The existing events do not expose the required in-scope state (the current Purchase Price record, the current best price, or PriceInSKU/SKU) at the right points, forcing subscribers to re-implement whole loops. This PR adds two new integration events inside the selection loop and extends one existing event so subscribers can override these decisions without duplicating internal logic.

Source issue repository: microsoft/AlAppExtensions; issue number: 30264

Changes Made

• OnCalcBestDirectUnitCostOnAfterIsInMinQty - new integration event raised right after the IsInMinQty call in the loop, exposing the PurchasePrice record, QtyPerUOM, Qty, and the min-quantity var Boolean result so subscribers can override which quantity the minimum is checked against per price record. The IsInMinQty result is now stored in a new local InMinQty variable that drives the loop.
• OnCalcBestDirectUnitCostOnBeforeCaseStatement - new integration event raised after the price conversions and before the case true of selection block, exposing PurchasePrice, BestPurchasePrice, BestPurchPriceFound, a var IsHandled skip flag, and LineDiscPerCent so subscribers can replace the best-price selection rule; the standard case block runs only when IsHandled is false.
• OnCalcBestDirectUnitCostOnBeforeNoPriceFound - extended with var PriceInSKU: Boolean and var StockkeepingUnit: Record "Stockkeeping Unit" appended to the signature so subscribers can intercept the no-price fallback with full knowledge of the SKU state; the call site now passes PriceInSKU and SKU.

Fixes AB#641452

[github-actions]

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain	Findings	Knowledge-backed	Agent	Inline	Fallback
Events	1	1	0	1	0

Totals: 1 knowledge-backed · 0 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

• layer-disabled (knowledge) : 2 file(s)

_{Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.}

[github-actions]

⚠️ Stale Status Check Deleted

The Pull Request Build workflow run for this PR was older than 72 hours and has been deleted.

📋 Why was it deleted?

Status checks that are too old may no longer reflect the current state of the target branch. To ensure this PR is validated against the latest code and passes up-to-date checks, a fresh build is required.

---

🔄 How to trigger a new status check:

1. 📤 Push a new commit to the PR branch, or
2. 🔁 Close and reopen the PR

This will automatically trigger a new Pull Request Build workflow run.

[qasimikram]

The three publisher changes match the linked request and expose the required state at the intended decision points.

S1: Please add regression coverage for the new override paths. Include multiple candidate prices and verify default behavior, an overridden InMinQty result, and a handled selection that updates both BestPurchPrice and BestPurchPriceFound; also cover the extended no-price fallback context.

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Breaking\ Changes}$

The existing published IntegrationEvent "OnCalcBestDirectUnitCostOnBeforeNoPriceFound" changed its shipped signature by adding the new var parameters "PriceInSKU" and "StockkeepingUnit". Extensions that already subscribe to the old 3-parameter event will no longer compile or bind correctly. Keep the existing event signature unchanged and introduce a new companion event for the extra context instead.

Knowledge:

• microsoft/knowledge/breaking-changes/do-not-change-published-procedure-signatures.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.15.4}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Events}$

The new and changed event signatures introduce abbreviated subscriber-facing parameter names such as PriceInSKU, InMinQty, BestPurchPriceFound, and LineDiscPerCent. Event parameter names are part of the contract subscribers code against, so spell them out to make the publishers self-explanatory before this surface ships.

Knowledge:

• microsoft/knowledge/events/name-event-parameters-without-abbreviations.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.15.4}