salvage: fix HelloDrone image path when getImages empty (credit @webshared #4658)#9784
Open
Bartok9 wants to merge 1 commit into
Open
salvage: fix HelloDrone image path when getImages empty (credit @webshared #4658)#9784Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Invert empty-check so HelloDrone asks for a save path when simGetImages actually returned frames (not when the vector is empty). Salvage of microsoft#4658 by @webshared — rebased onto current main and re-verified (CRLF preserved). Spec: tools/aerial-drone-pr-campaign/specs/airsim/2026-07-16-salvage.md
Bartok9
force-pushed
the
salvage/hello-drone-image-save-4658-20260716
branch
from
July 16, 2026 09:23
d29b50c to
0ef0ce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
salvage: Fix inverted
response.size()guard inHelloDrone/main.cppso the image save path prompt runs when images were received.credit @webshared #4658 — rebased / re-applied on current
main(2026-07-16).Motivation
Original condition used
if (!response.size())before prompting to save, so success path was inverted (prompt on empty captures). Small example quality fix for first-run HelloDrone demos.Test plan
Notes
Does not change flight, geofences, or arming. Example client only.