-
Notifications
You must be signed in to change notification settings - Fork 16
Update docs and scripts for installation from COPR #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughAdds COPR/nightly RPM installation support: new RPM_SOURCE and COPR_REPO env vars, refactors quickrpm.sh to fetch helper scripts and branch install flows (github vs copr-nightly), and extends repo creation tooling with create_rhocp_repo and create_local_microshift_repo; updates docs to document COPR/nightly installs and networking requirements. (49 words) Changes
Sequence DiagramsequenceDiagram
participant User as User
participant Quick as quickrpm.sh
participant Downloader as download_script()
participant Repos as create_repos.sh
participant COPR as COPR
participant DNF as dnf
User->>Quick: RPM_SOURCE=copr-nightly ./quickrpm.sh
Quick->>Downloader: fetch create_repos.sh
Downloader-->>Quick: provide create_repos.sh
Quick->>Downloader: fetch postinstall.sh
Downloader-->>Quick: provide postinstall.sh
Quick->>Repos: request enable COPR / create RHOC P mirror (-rhocp-mirror)
Repos->>COPR: query nightly repo/version metadata
COPR-->>Repos: return metadata
Repos-->>Quick: repo files created
Quick->>DNF: install microshift packages from COPR
DNF-->>Quick: install results
Quick->>Quick: run postinstall.sh / start service
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/quickrpm.sh`:
- Line 79: Fix the typo in the comment: replace the misspelled word "greeboot"
with "greenboot" in src/quickrpm.sh (the comment line containing "# Fedora
doesn't have old packages - downgrading greeboot is not possible."). Ensure the
corrected comment reads "# Fedora doesn't have old packages - downgrading
greenboot is not possible." so it's clear and accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@README.md`:
- Around line 53-57: The README's installation snippet uses "sudo
RPM_SOURCE=copr-nightly bash" which can lose the RPM_SOURCE env var under sudo;
update the command in the README to use "sudo env RPM_SOURCE=copr-nightly bash"
so the RPM_SOURCE is preserved when invoking the quickrpm.sh script (update the
code block that currently contains "curl -s
https://microshift-io.github.io/microshift/quickrpm.sh | sudo
RPM_SOURCE=copr-nightly bash" to the env-preserving form).
In `@src/quickrpm.sh`:
- Around line 62-78: The download_script function uses an undefined variable
scriptdir when copying the local RPM script which breaks under set -u; update
the local-copy cp invocation to use the already-defined curscriptdir (i.e.,
replace "${scriptdir}/../${scriptpath}" with "${curscriptdir}/../${scriptpath}")
so the local path check and copy succeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/rpm/create_repos.sh (1)
74-81: Consider preserving stderr for debugging failed queries.Redirecting stderr to
/dev/nullon line 75 hides potential dnf errors that could help diagnose why version detection fails.♻️ Suggested improvement
--rhocp-mirror) - repo_version=$(dnf repoquery --qf '%{VERSION}' --latest-limit=1 microshift 2>/dev/null | cut -d. -f1,2) + repo_version=$(dnf repoquery --qf '%{VERSION}' --latest-limit=1 microshift | cut -d. -f1,2) if [ -z "${repo_version}" ] ; then echo "ERROR: Failed to find version of MicroShift available in the repositories" usage
Closes #195
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.