Skip to content

fix: remove duplicate status check and add missing port flag description in start command #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
A-d-i-t-y wants to merge 2 commits into from
+3 −7
Closed

fix: remove duplicate status check and add missing port flag description in start command #437

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b675e4
fix: remove duplicate status check and add missing port flag descript…
A-d-i-t-y May 25, 2026
dfc72da
Merge branch 'master' into fix/start-command-improvements
A-d-i-t-y May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions cmd/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,7 @@ microcks start --name [name of you container/instance]`,
instance = &config.Instance{}
}

if instance.Status == "Running" {
fmt.Printf("Microcks instance with name %s is already running", name)
return
}


switch instance.Status {
case "Running":
fmt.Printf("Microcks instance with name %s is already running", name)
Expand Down Expand Up @@ -143,8 +139,8 @@ microcks start --name [name of you container/instance]`,
fmt.Printf("Microcks started successfully at %s\n", server)
},
}
startCmd.Flags().StringVar(&name, "name", "microcks", "name for your Microcks instance")
startCmd.Flags().StringVar(&hostPort, "port", "8585", "Host port to expose Microcks")
startCmd.Flags().StringVar(&name, "name", "microcks", "name for you microcks instance")
startCmd.Flags().StringVar(&hostPort, "port", "8585", "Host port to expose the Microcks instance (default: 8585)")
startCmd.Flags().StringVar(&imageName, "image", "quay.io/microcks/microcks-uber:latest-native", "image which will be used to create a container")
startCmd.Flags().BoolVar(&autoRemove, "rm", false, "mimic of '--rm' flag of Docker to automatically remove the container when it exits")
startCmd.Flags().StringVar(&driver, "driver", "docker", "use --driver to change driver from docker to podman")
Expand Down