Skip to content

fix: validate numeric part of --waitFor flag in test command #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A-d-i-t-y wants to merge 2 commits into
base: master
Choose a base branch
from
+29 −5
Open

fix: validate numeric part of --waitFor flag in test command #431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ff984d
fix: validate numeric part of --waitFor flag in test command
A-d-i-t-y May 24, 2026
44d20e3
Merge branch 'master' into fix/waitfor-flag-validation
A-d-i-t-y May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions cmd/test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,33 @@ func NewTestCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command {
}

// Validate presence and values of flags.
if !strings.HasSuffix(waitFor, "milli") && !strings.HasSuffix(waitFor, "sec") && !strings.HasSuffix(waitFor, "min") {
fmt.Println("--waitFor format is wrong. Accepted units are: milli, sec, min (e.g. 500milli, 30sec, 5min)")
os.Exit(1)
}
if !strings.HasSuffix(waitFor, "milli") && !strings.HasSuffix(waitFor, "sec") && !strings.HasSuffix(waitFor, "min") {
fmt.Println("--waitFor format is wrong. Accepted units are: milli, sec, min (e.g. 500milli, 30sec, 5min)")
os.Exit(1)
}

// Validate that numeric part of --waitFor is present and greater than zero.
var numericPart string
if strings.HasSuffix(waitFor, "milli") {
numericPart = waitFor[:len(waitFor)-5]
} else if strings.HasSuffix(waitFor, "sec") {
numericPart = waitFor[:len(waitFor)-3]
} else if strings.HasSuffix(waitFor, "min") {
numericPart = waitFor[:len(waitFor)-3]
}
if numericPart == "" {
fmt.Printf("--waitFor value %q is missing numeric part (e.g. 5sec, 500milli, 1min)\n", waitFor)
os.Exit(1)
}
numericVal, err := strconv.ParseInt(numericPart, 0, 64)
if err != nil {
fmt.Printf("--waitFor value %q has invalid numeric part: must be a valid integer\n", waitFor)
os.Exit(1)
}
if numericVal <= 0 {
fmt.Printf("--waitFor value %q must be greater than zero\n", waitFor)
os.Exit(1)
}

// Collect optional HTTPS transport flags.
config.InsecureTLS = globalClientOpts.InsecureTLS
Expand Down Expand Up @@ -165,7 +188,8 @@ func NewTestCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command {
serverAddr = ctx.Server.Server
}

testResultID, err := mc.CreateTestResult(serviceRef, testEndpoint, runnerType, secretName, waitForMilliseconds, filteredOperations, operationsHeaders, oAuth2Context)
var testResultID string
testResultID, err = mc.CreateTestResult(serviceRef, testEndpoint, runnerType, secretName, waitForMilliseconds, filteredOperations, operationsHeaders, oAuth2Context)
if err != nil {
fmt.Printf("Got error when invoking Microcks client creating Test: %s", err)
os.Exit(1)
Expand Down