config: Don't panic on plugin JSON files without a plugin entry - #4247
Merged
Merged
Conversation
A .json file in a plugin directory that decodes to an empty list (`[]` or `null`) made NewPluginInfo index info[0] on an empty slice. The panic happens in InitPlugins(), before the recover() in main(), and the deferred exit(0) ends micro silently with status 0 on every start. A file whose first entry has no Name did not crash, but it replaced the plugin name with an empty string, so the plugin was dropped as "not a plugin". Return the existing ErrMissingName in both cases. InitPlugins() already skips files that fail to parse, so the plugin keeps its directory name.
JoeKar
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a
.jsonfile in a plugin directory contains[]ornull,NewPluginInfo(internal/config/plugin_manager.go) indexesinfo[0]on an empty slice. the panic happens inInitPlugins(), before therecover()inmain(), so the deferredexit(0)quits micro on every start with status 0 and no message. a file whose first entry has noNamedoesn't crash, but it blanks the plugin name and the plugin is droppedNewPluginInfonow returns the existingErrMissingNamefor both. the callers already skip files that fail to parse, so the plugin keeps its directory name. the newTestNewPluginInfoRejectsMissingNamepanicked before the change and passes now