Skip to content

Update nim syntax to nim 2.0+ #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5BNeumann wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update nim syntax to nim 2.0+ #4237

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
062655c
Update nim.yaml to nim 2.0+
5BNeumann Sep 20, 2026
7d1c910
I struggle with github ok, I'm used to CLI git...
5BNeumann Sep 20, 2026
3a7e889
Fix issues in the updated syntax
5BNeumann Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 37 additions & 6 deletions runtime/syntax/nim.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,42 @@ rules:
- constant.number: "\\b0[ocC][0-7][0-7_]+\\b"
- constant.number: "\\b0[bB][01][01_]+\\b"
- constant.number: "\\b[0-9_]((\\.?)[0-9_]+)?[eE][+\\-][0-9][0-9_]+\\b"
- constant.string: "\"(\\\\.|[^\"])*\"|'(\\\\.|[^'])*'"
- comment: "[[:space:]]*(?:[^\\\\]|^)#.*$"
- comment:
start: "\\#\\["
end: "\\]\\#"

- constant.string:
start: "\""
end: "(\"|$)"
skip: "\\\\."
rules:
- constant.specialChar: "\\\\([\"'abceflnprtv\\\\]|\\d+|x[0-9A-Fa-f]{2}|u[0-9A-Fa-f]{4}|u\\{[0-9A-Fa-f]+\\})"

- constant.string:
start: "(r|R)\""
end: "(\"|$)"
skip: "\\\\."
rules: []

- constant.string:
start: "\"\"\""
end: "\"\"\""

@Andriamanitra Andriamanitra Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be quite right.

The ending of the string literal is defined by the pattern """[^"], so this:
""""long string within quotes""""
Produces:
"long string within quotes"

https://nim-lang.org/docs/manual.html#lexical-analysis-triple-quoted-string-literals

@5BNeumann 5BNeumann Sep 22, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how the python3 syntax handles multi-line comments and it works pretty much how it should with the new changes. (""""long string within quotes"""" does give the expected result which was not the case prior to the newest commit.)

skip: "\\\\."
rules: []

- todo: "(TODO|FIXME|XXX):?"
- constant.string:
start: "'"
end: "('|$)"
skip: "\\\\."
rules:
- error: "[[:graph:]]{2,}'"
- constant.specialChar: "\\\\([\"'abceflnprtv\\\\]|\\d+|x[0-9A-Fa-f]{2}|u[0-9A-Fa-f]{4}|u\\{[0-9A-Fa-f]+\\})"

- comment:
start: "#\\["
end: "\\]#"
rules:
- todo: "(TODO|FIXME|XXX):?"

- comment:
start: "#"
end: "$"
rules:
- todo: "(TODO|FIXME|XXX):?"