Skip to content

fix: parse plugin repo metadata as JSON5#4116

Open
puneetdixit200 wants to merge 1 commit into
micro-editor:masterfrom
puneetdixit200:fix-plugin-info-json5
Open

fix: parse plugin repo metadata as JSON5#4116
puneetdixit200 wants to merge 1 commit into
micro-editor:masterfrom
puneetdixit200:fix-plugin-info-json5

Conversation

@puneetdixit200
Copy link
Copy Markdown

Fixes #4084.

Summary

  • Decode installed plugin repo.json metadata with json5, matching the plugin installer and channel/repository decoding paths.
  • Add a regression test covering a repo.json payload with a JSON5 comment.

Tests

  • Red before fix: go test ./internal/config -run TestNewPluginInfoAllowsJSON5Comments -count=1 failed with invalid character '/' looking for beginning of value
  • go test ./internal/config -run TestNewPluginInfoAllowsJSON5Comments -count=1
  • go test ./internal/config -count=1
  • go test ./...
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repo.json inconsistently decoded (JSON5 vs JSON)

2 participants