Improve justfile syntax #3018
Open
Improve justfile syntax #3018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taconi
approved these changes
Mar 17, 2024
pbsds
approved these changes
Mar 14, 2025
Andriamanitra
force-pushed
the
update-justfile-syntax
branch
from
6474fd0 to
066e8a7
Compare
Contributor
Author
|
I've rebased & squashed the commits, is there anything still blocking this from being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current justfile syntax is mostly copied from
Makefilesyntax. Some of those rules don't even exist injust, and it was also missing a bunch of just-specific syntax. The detect filename attribute was also broken when you opened a justfile from a different directory because of the^.I may have made the syntax file a bit more advanced than it needs to be (some of the rules rely on the order they are declared in) but I think it's still a solid improvement.
Here's a comparison between old (left) and new (right):