Fix CMake generator expression (backport #30) - #32
Closed
mergify[bot] wants to merge 1 commit into
Closed
Conversation
(cherry picked from commit dc07301) # Conflicts: # rcl/CMakeLists.txt
Author
|
Cherry-pick of dc07301 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Author
|
Tick the box to add this pull request to the merge queue (same as
|
|
Change not needed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the kilted branch of micro-ROS/micro_ros_espidf_component, I get the following error:
This appears to be caused by unquoted generator expressions being split at semicolons. This issue only seems to occur with older versions of CMake. I'm using CMake 3.22.1.
Local testing confirms that the project builds successfully after the generator expressions are quoted.
This is an automatic backport of pull request #30 done by Mergify.