Keep track of baseUrl root path and handle path-absolute resources.#851
Open
aivins wants to merge 2 commits intomgonto:masterfrom
Open
Keep track of baseUrl root path and handle path-absolute resources.#851aivins wants to merge 2 commits intomgonto:masterfrom
aivins wants to merge 2 commits intomgonto:masterfrom
Conversation
|
@aivins, would that work when the self link is relative to the API root? e.g. |
alexjpaz
added a commit
to alexjpaz-archive/pazfit2-ui-web
that referenced
this pull request
Nov 21, 2014
Collaborator
|
I think this should be good; I need to read it again and test it more thoroughly. A couple items tho:
|
Collaborator
|
Any chance of this getting merged anytime soon? I'm seeing quite a few open issues relating to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to issue #620.
API endpoint returns a path-absolute self link, such as /api/v1/person/5.
baseUrl setting includes part of this path, such as http://some.host:8000/api/v1/.
baseUrlRoot will be set to http://some.host:8000.
If setSelfLinkAbsoluteUrl is not true, then a second check will happen to see if the self link begins with a slash. If so it is treated as path-relative and appended to baseUrlRoot.
This covers my own issues with self links cross domain as well as the path-absolute issues touched upon in #620.