fix(codegen): make prompt-payload field typing declared-type-authoritative (#270)

[dmealing]

Intent

Unit A of the projection/payload vocabulary batch (#270): make prompt-payload field typing declared-type-authoritative in the Kotlin, Python AND Java payload-VO generators. A payload field's type must come ONLY from its declared field. + @isarray + @objectref, and nullability must NEVER be derived from origin semantics.

The bug: on origin.collection, the payload generators discarded the field's declared @objectref and substituted the @via relationship's target entity, so a declared curated value-object silently became the FULL entity - payload bloat invisible in a diff, which defeats the whole point of the prompt-construction pillar. Separately @agg count hardwired a long type over the declared subtype, and passthrough/computed/first overrode declared types and nullability.

Scope note a reviewer could not infer: the issue as filed named only Kotlin and Python, because the original recon reported Java as an origin-blind reference port. That was FALSE - SpringPayloadGenerator carried the identical origin dispatch. The recon missed it because this environment's grep wrapper passes -I (skip binary) and the file contained raw NUL bytes in string literals, so the search silently returned nothing. The maintainer explicitly ruled to fix Java too rather than narrow the ruling, because the follow-on #210 work makes payloads projections and projections legitimately carry assembly origins - so the dispatch would fire on the shape that becomes the norm. Hence Java is in this diff despite the issue title.

TypeScript and C# were genuinely origin-blind and are the reference implementations. Their PRODUCT code is deliberately untouched so npm and NuGet stay version-parity bumps under the one-shared-patch release policy - but each gained one regression pin in its TEST files, because nothing cross-port gated payload typing and that is precisely how this bug survived long enough to be written into a ruling as settled fact.

Also deliberate in this diff: the origin.collection edge is deleted from the ADR-0044 name-map closure that each port shares with its extract tier (#228), in lockstep per port. Java now honors declared @isarray on plain scalars (bare T becomes java.util.List) - Kotlin and Python already did, and leaving it would have meant our own change silently dropped array-ness. Two raw NUL bytes in Java string literals became \0 escapes (runtime-identical; they were composite-map-key delimiters written as literal 0x00). Kotlin comments now state that fallbackType() THROWS rather than degrading to a scalar - the comment was wrong, and correcting the behavior is deliberately left to #210.

Deliberately NOT fixed, with reasons: Python's declared closure edge is not subtype-filtered to object.value while Kotlin's and Java's are - an independent adjudication overturned an earlier decision to add the filter, because TS and C# do not filter either, and filtering the payload closure without the extract closure would emit mappers constructing classes that no longer exist; the real fix is a fail-closed loader validation owned by #210. Java's extract mapper passes asStringList for every scalar-array subtype - pre-existing, untouched, and this change strictly improved the string case (that shape previously did not compile).

Constraints honored: no new metamodel vocabulary, attributes or error codes (ADR-0023); resolving accessors only, no own*() reads (ADR-0039); the codegen-kotlin payload-with-origins snapshot is byte-identical, which is the declared==derived gate.

Already cleared by: an independent task review, a Fable adjudication that overturned one of its findings, two fix rounds, a release-grade whole-branch review, and a scoped re-review. This is the last gate before a coordinated 0.20.16 / 7.20.16 patch to Maven Central and PyPI.

What Changed

• Payload-VO generators (Kotlin, Python, Java) now derive a payload field's type only from its declared field.<subType> + @isArray + @objectRef; origin.collection/aggregate/passthrough/computed/first children no longer override the declared type or its nullability. This stops a declared curated value-object on origin.collection from silently expanding to the full target entity, and @agg: count from hardwiring long over the declared subtype.
• Java payload records now honor a declared @isArray on plain scalars (bare T → java.util.List<T>), matching the Kotlin and Python emitters; the origin.collection edge is dropped from the ADR-0044 name-map closure shared with each port's extract tier, in lockstep per port.
• Added cross-port regression pins in the TS, C#, Kotlin, Python, and Java payload-generator suites (TS/C# product code deliberately untouched so npm/NuGet stay version-parity bumps), and aligned the docs, agent-context skills, and inline comments to the declared-type-authoritative contract.

Risk Assessment

✅ Low: No actionable findings: the declared-type-authoritative fix is correctly implemented across Kotlin/Java/Python, gated by comprehensive cross-port tests, mirrored reference-emitter pins (TS/C#), and a byte-identical Kotlin snapshot for the declared==derived case; all behavior changes are the intended fix, and the remaining edge cases are explicitly authorized containment scoped to #210.

Testing

All targeted validation passes with generated-code evidence across every port: Python (27 tests + rendered payloads), Java (21 tests + rendered records), Kotlin (20 unit tests + 14 byte-identical snapshot tests incl. the declared==derived payload-with-origins gate), plus the TS and C# reference-emitter regression pins. The headline payload-bloat bug is shown fixed in actual emitted code — a declared curated Highlight VO wins over the @via Post entity, and Java's @isArray-on-scalars fix renders List<String>. No failures, no flakiness, working tree left clean.

Evidence: Java rendered payload records (disagreement + scalar-array) — generated code an end user receives

===== SCENARIO A: disagreement (declared @objectRef Highlight vs @via entity Post) ===== AuthorDigestViewPayload.java exists : true HighlightPayload.java (curated) exists: true PostPayload.java (@via entity) exists : false (must be false) ---------- AuthorDigestViewPayload.java ---------- public record AuthorDigestViewPayload( java.util.List<HighlightPayload> posts // DECLARED curated VO wins, NOT @via entity Post ) { ... } ---------- HighlightPayload.java ---------- public record HighlightPayload( String snippet ) { ... } ===== SCENARIO B: declared @isArray on a plain scalar ===== public record TagViewPayload( java.util.List<String> tags // #270 round 2: bare String -> List<String> ) { ... }

===== SCENARIO A: disagreement (declared @objectRef Highlight vs @via entity Post) =====
AuthorDigestViewPayload.java exists : true
HighlightPayload.java (curated) exists: true
PostPayload.java (@via entity) exists : false  (must be false)

---------- AuthorDigestViewPayload.java ----------
package acme.demo.prompts;

/** GENERATED — payload for template `acme::demo::AuthorDigestView`. Do not hand-edit; regenerated from metadata. */
public record AuthorDigestViewPayload(
    java.util.List<HighlightPayload> posts
) {
    public boolean hasPosts() { return posts != null && !posts.isEmpty(); }
}


---------- HighlightPayload.java ----------
package acme.demo.prompts;

/** GENERATED — nested payload for `acme::demo::Highlight`. Do not hand-edit; regenerated from metadata. */
public record HighlightPayload(
    String snippet
) {
    public boolean hasSnippet() { return snippet != null && !snippet.isBlank(); }
}


===== SCENARIO B: declared @isArray on a plain scalar (tags: List<String>) =====

---------- TagViewPayload.java ----------
package acme.demo.prompts;

/** GENERATED — payload for template `acme::demo::TagView`. Do not hand-edit; regenerated from metadata. */
public record TagViewPayload(
    java.util.List<String> tags
) {
    public boolean hasTags() { return tags != null && !tags.isEmpty(); }
}

Evidence: Python rendered Pydantic payload (disagreement: declared curated VO wins; origins ignored for typing)

SCENARIO 1 — class HighlightPayload(BaseModel): snippet: str | None = None class AuthorDigestOutputPayload(BaseModel): posts: list[HighlightPayload] | None = None --- assertion summary --- declared VO wins : posts: list[HighlightPayload] -> True curated class : class HighlightPayload present -> True entity bloat : PostPayload present -> False (must be False) internal field : internalNotes present -> False (must be False) SCENARIO 2 — origin.* IGNORED: 'alias: int' wins=True; 'total: str' (@agg count) wins=True; 'avgScore: str' (@agg avg) wins=True

==============================================================================
SCENARIO 1 — disagreement: declared @objectRef (Highlight) vs @via entity (Post)
==============================================================================
# @generated by metaobjects — DO NOT EDIT.
# Source metadata: AuthorDigestOutput (acme::ai::AuthorDigestOutput)
# Customize via AuthorDigestOutput_extra.py in this directory.

from __future__ import annotations

from pydantic import BaseModel


class HighlightPayload(BaseModel):
    """GENERATED nested payload for object field target ``Highlight``."""
    snippet: str | None = None


class AuthorDigestOutputPayload(BaseModel):
    """GENERATED payload for template ``AuthorDigestOutput``.

    Field shape derived from the ``AuthorDigest`` object.value."""
    posts: list[HighlightPayload] | None = None


__all__ = ["AuthorDigestOutputPayload", "HighlightPayload"]


--- assertion summary ---
declared VO wins : posts: list[HighlightPayload]  -> True
curated class    : class HighlightPayload present -> True
entity bloat     : PostPayload present            -> False (must be False)
internal field    : internalNotes present         -> False (must be False)

==============================================================================
SCENARIO 2 — origin.* IGNORED for typing: declared subtype wins
==============================================================================
  passthrough over STRING source, declared int
    -> 'alias: int | None = None'   wins=True
  @agg count, declared string
    -> 'total: str | None = None'   wins=True
  @agg avg, declared string
    -> 'avgScore: str | None = None'   wins=True

Evidence: Generated Java record — AuthorDigestViewPayload.java (declared List<HighlightPayload>)

package acme.demo.prompts;

/** GENERATED — payload for template `acme::demo::AuthorDigestView`. Do not hand-edit; regenerated from metadata. */
public record AuthorDigestViewPayload(
    java.util.List<HighlightPayload> posts
) {
    public boolean hasPosts() { return posts != null && !posts.isEmpty(); }
}

Evidence: Generated Java record — curated HighlightPayload.java (emitted, not the fuller Post)

package acme.demo.prompts;

/** GENERATED — nested payload for `acme::demo::Highlight`. Do not hand-edit; regenerated from metadata. */
public record HighlightPayload(
    String snippet
) {
    public boolean hasSnippet() { return snippet != null && !snippet.isBlank(); }
}

Evidence: Generated Java record — TagViewPayload.java (List<String>: declared @isarray on plain scalar honored)

package acme.demo.prompts;

/** GENERATED — payload for template `acme::demo::TagView`. Do not hand-edit; regenerated from metadata. */
public record TagViewPayload(
    java.util.List<String> tags
) {
    public boolean hasTags() { return tags != null && !tags.isEmpty(); }
}

Evidence: Java Spring payload test results — all 11 new #270 methods PASS (per surefire XML)

class: com.metaobjects.generator.spring.SpringPayloadGeneratorTest | tests: 21 | failures: 0 | errors: 0
--- new #270 methods ---
  PASS  scalarArrayWithDisagreeingOriginCollectionStillEmitsListOfElementType
  PASS  originAggregateAvgIgnoredDeclaredTypeWins
  PASS  originCarryingObjectFieldStaysInNameMapClosure
  PASS  originCollectionOnlyFieldContributesNothingToNameMap
  PASS  originAggregateSumIgnoredDeclaredTypeWins
  PASS  scalarArrayFieldEmitsListComponent
  PASS  originCollectionIgnoredNoNestedPayloadEmitted
  PASS  originAggregateCountIgnoredDeclaredTypeWins
  PASS  originCollectionIgnoredAcrossMultipleTemplates
  PASS  originPassthroughIgnoredDeclaredTypeWins
  PASS  disagreeingOriginCollectionDeclaredObjectRefWins

Evidence: Standalone Java evidence driver (compiled against codegen-spring test classpath; source tree untouched)

import com.metaobjects.generator.spring.SpringPayloadGenerator;
import com.metaobjects.generator.spring.SpringTestFixtures;
import com.metaobjects.loader.MetaDataLoader;

import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardCopyOption;
import java.util.HashMap;
import java.util.Map;

/**
 * Standalone evidence driver (#270) — runs SpringPayloadGenerator on the
 * load-bearing "disagreement" fixture (curated @objectRef Highlight vs a fuller
 * @via entity Post) and on the scalar-array fixture, then prints the emitted
 * Java payload records so a reviewer sees the actual generated Java code an end
 * user receives: the DECLARED type wins; the @via entity never leaks.
 *
 * Kept in the evidence directory and compiled against the codegen-spring test
 * classpath — it does not touch the source tree.
 */
public class PayloadEvidence {

    static final String DISAGREE = """
        {
          "metadata.root": { "package": "acme::demo", "children": [
            { "object.entity": { "name": "Author", "children": [
                { "field.long": { "name": "id" } },
                { "relationship.aggregation": { "name": "posts",
                    "@objectRef": "Post", "@cardinality": "many" } }
            ] } },
            { "object.entity": { "name": "Post", "children": [
                { "field.long":   { "name": "id" } },
                { "field.string": { "name": "title" } },
                { "field.string": { "name": "body" } },
                { "field.string": { "name": "internalNotes" } }
            ] } },
            { "object.value": { "name": "Highlight", "children": [
                { "field.string": { "name": "snippet" } }
            ] } },
            { "object.value": { "name": "AuthorDigest", "children": [
                { "field.object": { "name": "posts", "@objectRef": "Highlight",
                    "isArray": true, "children": [
                        { "origin.collection": { "@via": "Author.posts" } }
                    ] } }
            ] } },
            { "template.prompt": { "name": "AuthorDigestView",
                "@payloadRef": "AuthorDigest", "@textRef": "demo/digest" } }
          ] }
        }
        """;

    static final String SCALAR_ARRAY = """
        {
          "metadata.root": { "package": "acme::demo", "children": [
            { "object.entity": { "name": "Author", "children": [
                { "field.long": { "name": "id" } },
                { "relationship.aggregation": { "name": "posts",
                    "@objectRef": "Post", "@cardinality": "many" } }
            ] } },
            { "object.entity": { "name": "Post", "children": [
                { "field.long":   { "name": "id" } },
                { "field.string": { "name": "internalNotes" } }
            ] } },
            { "object.value": { "name": "TagList", "children": [
                { "field.string": { "name": "tags", "isArray": true, "children": [
                    { "origin.collection": { "@via": "Author.posts" } }
                ] } }
            ] } },
            { "template.prompt": { "name": "TagView",
                "@payloadRef": "TagList", "@textRef": "demo/tags" } }
          ] }
        }
        """;

    public static void main(String[] args) throws Exception {
        Path evi = Path.of(args[0]);
        Files.createDirectories(evi);
        Path ws = Files.createTempDirectory("payload-evi");

        // ---- Scenario A: disagreement (curated VO vs @via entity) ----
        Path outA = ws.resolve("outA");
        Files.createDirectories(outA);
        MetaDataLoader loaderA = SpringTestFixtures.loadFixture(ws, "disagree", DISAGREE);
        SpringPayloadGenerator genA = new SpringPayloadGenerator();
        Map<String, String> a = new HashMap<>();
        a.put("outputDir", outA.toString());
        genA.setArgs(a);
        genA.execute(loaderA);

        Path parentA = outA.resolve("acme/demo/prompts/AuthorDigestViewPayload.java");
        Path curatedA = outA.resolve("acme/demo/prompts/HighlightPayload.java");
        Path entityA = outA.resolve("acme/demo/prompts/PostPayload.java");
        System.out.println("===== SCENARIO A: disagreement (declared @objectRef Highlight vs @via entity Post) =====");
        System.out.println("AuthorDigestViewPayload.java exists : " + Files.exists(parentA));
        System.out.println("HighlightPayload.java (curated) exists: " + Files.exists(curatedA));
        System.out.println("PostPayload.java (@via entity) exists : " + Files.exists(entityA) + "  (must be false)");
        System.out.println("\n---------- AuthorDigestViewPayload.java ----------");
        System.out.println(Files.readString(parentA));
        System.out.println("\n---------- HighlightPayload.java ----------");
        System.out.println(Files.readString(curatedA));
        // Copy generated artifacts into the evidence dir.
        Files.copy(parentA, evi.resolve("java-AuthorDigestViewPayload.java"), StandardCopyOption.REPLACE_EXISTING);
        Files.copy(curatedA, evi.resolve("java-HighlightPayload.java"), StandardCopyOption.REPLACE_EXISTING);

        // ---- Scenario B: scalar array (@isArray honored on plain scalars) ----
        Path outB = ws.resolve("outB");
        Files.createDirectories(outB);
        MetaDataLoader loaderB = SpringTestFixtures.loadFixture(ws, "scalararray", SCALAR_ARRAY);
        SpringPayloadGenerator genB = new SpringPayloadGenerator();
        Map<String, String> b = new HashMap<>();
        b.put("outputDir", outB.toString());
        genB.setArgs(b);
        genB.execute(loaderB);

        Path tagFile = outB.resolve("acme/demo/prompts/TagViewPayload.java");
        System.out.println("\n===== SCENARIO B: declared @isArray on a plain scalar (tags: List<String>) =====");
        System.out.println("\n---------- TagViewPayload.java ----------");
        System.out.println(Files.readString(tagFile));
        Files.copy(tagFile, evi.resolve("java-TagViewPayload.java"), StandardCopyOption.REPLACE_EXISTING);
    }
}

Evidence: Python evidence-render script (reuses the test builders)

"""Evidence script (#270) — render the load-bearing payload scenarios and print
the generated payload modules so a reviewer can see, in the actual generated
code an end user receives, that payload typing is DECLARED-TYPE-AUTHORITATIVE.

Reuses the same builders as the Python test suite.
"""
from __future__ import annotations

import metaobjects.core_types  # noqa: F401  side-effect: registers attr classes
from metaobjects.codegen.generators.payload_vo_generator import render_payload_vo
from metaobjects.meta.core.field import field_constants as fc
from metaobjects.meta.core.field.meta_field import MetaField
from metaobjects.meta.core.object.meta_object import MetaObject
from metaobjects.meta.core.relationship.meta_relationship import MetaRelationship
from metaobjects.meta.core.relationship.relationship_constants import (
    RELATIONSHIP_ATTR_OBJECT_REF,
    RELATIONSHIP_SUBTYPE_COMPOSITION,
)
from metaobjects.meta.meta_root import MetaRoot
from metaobjects.meta.persistence.origin.meta_origin import MetaOrigin
from metaobjects.meta.persistence.origin.origin_constants import (
    ORIGIN_ATTR_AGG,
    ORIGIN_ATTR_FROM,
    ORIGIN_ATTR_OF,
    ORIGIN_ATTR_VIA,
    ORIGIN_SUBTYPE_AGGREGATE,
    ORIGIN_SUBTYPE_COLLECTION,
    ORIGIN_SUBTYPE_PASSTHROUGH,
)
from metaobjects.meta.template import template_constants as tc
from metaobjects.meta.template.meta_template import MetaTemplate
from metaobjects.shared.base_types import (
    SUBTYPE_ROOT,
    TYPE_FIELD,
    TYPE_METADATA,
    TYPE_OBJECT,
    TYPE_ORIGIN,
    TYPE_RELATIONSHIP,
    TYPE_TEMPLATE,
)


def _field(name, sub):
    return MetaField(TYPE_FIELD, sub, name)


def _field_with_origin(name, sub, origin):
    f = MetaField(TYPE_FIELD, sub, name)
    f.add_child(origin)
    return f


def _object_field(name, object_ref, *, is_array=False):
    f = MetaField(TYPE_FIELD, fc.FIELD_SUBTYPE_OBJECT, name)
    f.set_attr(fc.FIELD_ATTR_OBJECT_REF, object_ref)
    f.is_array = is_array
    return f


def _passthrough(from_ref):
    o = MetaOrigin(TYPE_ORIGIN, ORIGIN_SUBTYPE_PASSTHROUGH, "from")
    o.set_attr(ORIGIN_ATTR_FROM, from_ref)
    return o


def _aggregate(agg, *, of=None, via="Parent.rel"):
    o = MetaOrigin(TYPE_ORIGIN, ORIGIN_SUBTYPE_AGGREGATE, agg)
    o.set_attr(ORIGIN_ATTR_AGG, agg)
    if of is not None:
        o.set_attr(ORIGIN_ATTR_OF, of)
    o.set_attr(ORIGIN_ATTR_VIA, via)
    return o


def _collection(via):
    o = MetaOrigin(TYPE_ORIGIN, ORIGIN_SUBTYPE_COLLECTION, "via")
    o.set_attr(ORIGIN_ATTR_VIA, via)
    return o


def _value_object(name, fields, *, package=None):
    obj = MetaObject(TYPE_OBJECT, "value", name)
    obj.package = package
    for f in fields:
        obj.add_child(f)
    return obj


def _entity(name, fields, *, relationships=None):
    obj = MetaObject(TYPE_OBJECT, "entity", name)
    for f in fields:
        obj.add_child(f)
    for r in relationships or []:
        obj.add_child(r)
    return obj


def _relationship(name, object_ref):
    r = MetaRelationship(TYPE_RELATIONSHIP, RELATIONSHIP_SUBTYPE_COMPOSITION, name)
    r.set_attr(RELATIONSHIP_ATTR_OBJECT_REF, object_ref)
    return r


def _template(name, payload_ref, *, subtype=tc.TEMPLATE_SUBTYPE_OUTPUT):
    t = MetaTemplate(TYPE_TEMPLATE, subtype, name)
    t.set_attr(tc.TEMPLATE_ATTR_PAYLOAD_REF, payload_ref)
    if subtype != tc.TEMPLATE_SUBTYPE_TOOLCALL:
        t.set_attr(tc.TEMPLATE_ATTR_TEXT_REF, "tpl/x")
        t.set_attr(tc.TEMPLATE_ATTR_FORMAT, "json")
    return t


def _root(children, *, package="acme::ai"):
    root = MetaRoot(TYPE_METADATA, SUBTYPE_ROOT, "test")
    root.package = package
    for c in children:
        root.add_child(c)
    return root


def banner(title):
    line = "=" * 78
    print("\n" + line)
    print(title)
    print(line)


# ---------------------------------------------------------------------------
# Scenario 1 (LOAD-BEARING): a curated VO disagrees with a fuller @via entity.
# Before #270, the payload silently became the FULL entity (Post). Now the
# declared @objectRef (Highlight) wins and Post never appears.
# ---------------------------------------------------------------------------
banner("SCENARIO 1 — disagreement: declared @objectRef (Highlight) vs @via entity (Post)")
highlight = _value_object(
    "Highlight", [_field("snippet", fc.FIELD_SUBTYPE_STRING)], package="acme::ai"
)
post = _entity(
    "Post",
    [
        _field("id", fc.FIELD_SUBTYPE_LONG),
        _field("title", fc.FIELD_SUBTYPE_STRING),
        _field("body", fc.FIELD_SUBTYPE_STRING),
        _field("internalNotes", fc.FIELD_SUBTYPE_STRING),
    ],
)
author = _entity(
    "Author",
    [_field("id", fc.FIELD_SUBTYPE_LONG)],
    relationships=[_relationship("posts", "Post")],
)
disagreeing = _object_field("posts", "acme::ai::Highlight", is_array=True)
disagreeing.add_child(_collection("Author.posts"))
payload = _value_object("AuthorDigest", [disagreeing], package="acme::ai")
tmpl = _template("AuthorDigestOutput", "AuthorDigest")
root = _root([highlight, post, author, payload, tmpl])
out = render_payload_vo(tmpl, root)
print(out)

print("\n--- assertion summary ---")
print("declared VO wins : posts: list[HighlightPayload]  ->", "posts: list[HighlightPayload]" in out)
print("curated class    : class HighlightPayload present ->", "class HighlightPayload" in out)
print("entity bloat     : PostPayload present            ->", "class PostPayload" in out, "(must be False)")
print("internal field    : internalNotes present         ->", "internalNotes" in out, "(must be False)")

# ---------------------------------------------------------------------------
# Scenario 2: origins are IGNORED for typing on plain scalars.
# ---------------------------------------------------------------------------
banner("SCENARIO 2 — origin.* IGNORED for typing: declared subtype wins")
cases = [
    ("passthrough over STRING source, declared int", _field_with_origin(
        "alias", fc.FIELD_SUBTYPE_INT, _passthrough("Source.displayName")), "int"),
    ("@agg count, declared string", _field_with_origin(
        "total", fc.FIELD_SUBTYPE_STRING, _aggregate("count", of="Source.id")), "str"),
    ("@agg avg, declared string", _field_with_origin(
        "avgScore", fc.FIELD_SUBTYPE_STRING, _aggregate("avg", of="Source.score")), "str"),
]
for label, fld, expect in cases:
    src = _entity("Source", [_field("displayName", fc.FIELD_SUBTYPE_STRING),
                             _field("id", fc.FIELD_SUBTYPE_LONG),
                             _field("score", fc.FIELD_SUBTYPE_INT)])
    vo = _value_object("Shape", [fld])
    t = _template("ShapeOutput", "Shape")
    o = render_payload_vo(t, _root([src, vo, t]))
    got = f"{fld.name}: {expect}"
    print(f"  {label}\n    -> {''.join(l for l in o.splitlines() if fld.name in l).strip()!r}   wins={got in o}")

Pipeline

Updates from git push no-mistakes

✅ **intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

✅ **Review** - passed

✅ No issues found.

✅ **Test** - passed

✅ No issues found.

• cd server/python && uv run pytest tests/codegen/test_payload_vo_generator.py -v — 27/27 pass, incl. load-bearing test_disagreeing_origin_collection_declared_object_ref_wins and test_origin_*_ignored_declared_type_wins (passthrough/count/avg/sum/collection).
• PYTHONPATH=src uv run python /tmp/.../render_payloads.py — rendered actual Pydantic payload modules: disagreement scenario emits posts: list[HighlightPayload] + class HighlightPayload, no PostPayload/internalNotes; scalar-typing scenario shows alias: int, total: str, avgScore: str (origins ignored).
• mvn -o -pl codegen-spring test -Dtest=SpringPayloadGeneratorTest — 21/21 pass (11 new), incl. disagreeingOriginCollectionDeclaredObjectRefWins and scalarArrayFieldEmitsListComponent. Parsed surefire XML to confirm each new method ran+passed.
• Java standalone PayloadEvidence driver (compiled against codegen-spring test classpath, source tree untouched) — emitted real records: AuthorDigestViewPayload(java.util.List<HighlightPayload> posts), HighlightPayload(String snippet) (no PostPayload.java), and TagViewPayload(java.util.List<String> tags).
• mvn -o -pl codegen-kotlin test -Dtest='KotlinPayloadGeneratorTest,KotlinGenUtilTest,KotlinGenUtilAbstractTest' — 20/20 pass, incl. disagreeing origin-collection ... declared curated objectRef wins (issue-270) and issue-195 origins ... ignored.
• mvn -o -pl codegen-kotlin test -Dtest=KotlinCodegenSnapshotTest — 14/14 snapshot tests pass, incl. the payload-with-origins fixture (byte-identical AuthorBioPayload.kt with name: String, postCount: Long — the declared==derived gate).
• cd server/typescript/packages/codegen-ts && bun test test/payload-codegen.test.ts — 13/13 pass, incl. the new #270 reference-emitter pin (asserts posts: Highlight[], no Post/internalNotes).
• dotnet test MetaObjects.Codegen.Tests --filter PayloadGeneratorTests (server/csharp) — 5/5 pass, incl. new Origin_children_are_ignored_for_typing_declared_type_wins.
• Verified TS/C# product code untouched: git diff over server/typescript/**/src/** and server/csharp/MetaObjects*.cs (excl. tests) returns empty.
• Cleaned tree: restored server/python/uv.lock modified by uv sync; build outputs (.venv/node_modules/target/bin/obj) are gitignored and git status --porcelain is clean.

✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.