Fix TypeScript build by adding DOM lib to tsconfig#198
Closed
sania123b wants to merge 1 commit intometacall:masterfrom
Closed
Fix TypeScript build by adding DOM lib to tsconfig#198sania123b wants to merge 1 commit intometacall:masterfrom
sania123b wants to merge 1 commit intometacall:masterfrom
Conversation
Author
|
Please let me know if this approach aligns with the project configuration. |
Author
|
Did u checked?? |
Member
|
This is correct but I just added it on all repos for allowing new protocol version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes TypeScript build errors caused by missing DOM types
from @types/mapbox-gl.
Problem
Running
npm run buildresulted in multiple TypeScript errors such as:The errors were caused by missing DOM library definitions in tsconfig.json.
Solution
Added
"DOM"to thelibarray insidecompilerOptionsin tsconfig.json.After this change:
npm run buildcompletes successfullyTesting
Build verified locally using:
npm run build