[chore] Old layout cleanup - #1320
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
metabase-docs | 22cba0e | Sep 03 2026, 05:24 PM |
bpander
marked this pull request as ready for review
September 3, 2026 18:03
gantoreno
approved these changes
Sep 4, 2026
gantoreno
left a comment
Contributor
There was a problem hiding this comment.
Gotta love removing a bunch of unused code, nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The primary motivation for this is to alleviate my OCD but it'll also somewhat help with GRO-688. We'll probably stop building old versions every deployment, which means some stuff will need to be updated so it renders client-side (e.g. the copyright year, references to the latest version, etc); it simplifies things by only having one header+footer to deal with.
This only affects REALLY old version (like 36 and below) and it's not insane to think we'll completely retire those versions from the docs site, but that's a bigger conversation. And this does a big chunk of that work anyway.
Also, we'll probably purge unused CSS from this repo soon, and I think it'd be good to remove this old code before we do that (in case it means we can purge even more unused CSS).
How to test
This should be pretty low risk. It mostly removes a bunch of includes. If they were needed, the build would fail.
Just spot-check a few pages and the nav on some old versions like http://localhost:4321/docs/v0.36 and some new versions.
Demo
https://www.loom.com/share/8ee13246db4a4bbb90b9b9906a3d4012