Skip to content

[chore] Old layout cleanup - #1320

Merged
bpander merged 3 commits into
masterfrom
old-layout-cleanup
Sep 4, 2026
Merged

[chore] Old layout cleanup#1320
bpander merged 3 commits into
masterfrom
old-layout-cleanup

Conversation

@bpander

@bpander bpander commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

  1. Fixes old layout header + footer by just reusing the astro versions. Removes now unneeded code.
  2. Removes a committed stripe public key, which has never been used anywhere in this repo.

The primary motivation for this is to alleviate my OCD but it'll also somewhat help with GRO-688. We'll probably stop building old versions every deployment, which means some stuff will need to be updated so it renders client-side (e.g. the copyright year, references to the latest version, etc); it simplifies things by only having one header+footer to deal with.

This only affects REALLY old version (like 36 and below) and it's not insane to think we'll completely retire those versions from the docs site, but that's a bigger conversation. And this does a big chunk of that work anyway.

Also, we'll probably purge unused CSS from this repo soon, and I think it'd be good to remove this old code before we do that (in case it means we can purge even more unused CSS).

How to test

This should be pretty low risk. It mostly removes a bunch of includes. If they were needed, the build would fail.

Just spot-check a few pages and the nav on some old versions like http://localhost:4321/docs/v0.36 and some new versions.

Demo

https://www.loom.com/share/8ee13246db4a4bbb90b9b9906a3d4012

@bpander bpander self-assigned this Sep 3, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
metabase-docs 22cba0e Sep 03 2026, 05:24 PM

@bpander
bpander marked this pull request as ready for review September 3, 2026 18:03
@bpander
bpander requested a review from a team September 3, 2026 18:03

@gantoreno gantoreno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love removing a bunch of unused code, nice!

@bpander
bpander merged commit a2376f3 into master Sep 4, 2026
4 checks passed
@bpander
bpander deleted the old-layout-cleanup branch September 4, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants