Skip to content

Refactor resizeImage function for better resource handling #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psiddh merged 2 commits into from
Feb 25, 2026
Merged

Refactor resizeImage function for better resource handling #218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c08d7
Refactor resizeImage function for better resource handling
psiddh Feb 24, 2026
b354010
Recycle bitmap after extracting RGB values
psiddh Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions llm/android/LlamaDemo/app/src/main/java/com/example/executorchllamademo/ETImage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ class ETImage(
rgbValues[(y * width + x) + 2 * height * width] = blue.toByte()
}
}
bitmap.recycle()
return rgbValues
} catch (e: FileNotFoundException) {
throw RuntimeException(e)
Expand All @@ -87,15 +88,21 @@ class ETImage(
private fun resizeImage(uri: Uri, sideSize: Int): Bitmap? {
val inputStream = contentResolver.openInputStream(uri)
if (inputStream == null) {
ETLogging.getInstance().log("Unable to resize image, input streams is null")
ETLogging.getInstance().log("Unable to resize image, input stream is null")
return null
}
val bitmap = BitmapFactory.decodeStream(inputStream)
val bitmap = inputStream.use {
BitmapFactory.decodeStream(it)
}
if (bitmap == null) {
ETLogging.getInstance().log("Unable to resize image, bitmap during decode stream is null")
return null
}

return Bitmap.createScaledBitmap(bitmap, sideSize, sideSize, false)
val scaled = Bitmap.createScaledBitmap(bitmap, sideSize, sideSize, true) // ← bilinear
if (scaled !== bitmap) {
bitmap.recycle()
}
return scaled
}

}