Skip to content

Fix Print::printf return value on truncation and error #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
l5yth wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Print::printf return value on truncation and error #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d63d7
Fix Print::printf return value on truncation and error
l5yth Jun 2, 2026
6d5b516
Fix Print::printf return value on truncation and error
l5yth Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions cores/portduino/PortduinoPrint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ size_t Print::printf(const char *format, ...) {
// Linux that is fine, TBD on MyNewt
va_list args;
va_start(args, format);
size_t n = vsnprintf(buf, sizeof(buf), format, args);
write(buf);
int n = vsnprintf(buf, sizeof(buf), format, args);
va_end(args);
return n;
}
if (n <= 0) return 0;
// vsnprintf returns the would-be length; clamp to what actually fit.
size_t len = (n < (int)sizeof(buf)) ? (size_t)n : sizeof(buf) - 1;
return write((const uint8_t *)buf, len);
}