Skip to content

Fix LinuxHardwareI2C fd lifecycle #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
l5yth wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix LinuxHardwareI2C fd lifecycle #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cores/portduino/linux/LinuxHardwareI2C.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,14 @@ namespace arduino {
void LinuxHardwareI2C::begin(const char * device) {
if (!hasBegun) {
i2c_file = open(device, O_RDWR);
hasBegun = true;
if (i2c_file >= 0)
hasBegun = true;
}
}
void LinuxHardwareI2C::end() {
if (hasBegun) {
close(i2c_file);
i2c_file = -1;
hasBegun = false;
}
}
Expand Down
2 changes: 1 addition & 1 deletion cores/portduino/linux/LinuxHardwareI2C.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ enum ResultI2c {
};

class LinuxHardwareI2C : public HardwareI2C {
int i2c_file = 0;
int i2c_file = -1; // unopened: fail fast instead of operating on stdin/stdout

public:
void begin(const char* device);
Expand Down