Repository navigation
Conversation
Collaborator
|
interesting ... but I'm worried about possible side effects for other boards maybe you could add the busy loop into board.begin (it would fix this only for this specific board) |
Author
|
Done! I've also tested it plugged into a dumb charger on the ble firmware, just in case this poll loop needed it to be plugged in to a computer (it doesn't). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the Xiao ESP32-S3 Wio platform, there's a bug where USB communication doesn't work (#1416). For reasons not readily apparent to me, the cli never works if the firmware does not first wait for the serial port to be initialised, even several minutes later. The repeater firmware seems to have acknowledged this somehow, with a fixed delay of 1s before boot, but since I'm not 100% sure that this is the reason that line is there, I haven't touched it.
This PR adds the required wait, with a 10ms poll loop on
Serial.availableForWrite(). There may be other better fixes, but this is the one I (accidentally) happened upon: it works, and I'm happy to make changes if requested.