Fix ThinkNode M8 repeater/room server build: compile sensor helpers for all envs - #3509
Open
marcelverdult wants to merge 1 commit into
Open
marcelverdult wants to merge 1 commit into
marcelverdult wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThinkNode_M8_repeaterandThinkNode_M8_room_servercurrently fail to link ondev:variants/thinknode_m8/target.cppinstantiatesEnvironmentSensorManagerfor every env, butEnvironmentSensorManager.cppwas only added to the companion envs'build_src_filter. This moves+<helpers/sensors>into the shared[ThinkNode_M8]section (same as ThinkNode M3/M6) and drops the now-redundant per-env entries.Tested with
pio runondev(1934a49):ThinkNode_M8_repeater,_room_server,_companion_radio_ble,_companion_radio_usb,_kiss_modemall build. Without the change,_repeaterfails with the errors above.