Workaround for Heltec T096 transmit issue - #3182
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a temporary workaround for the Heltec T096 transmit issue (#3151)
The root issue seems to be that compiler optimisations are causing an ordering issue resulting in the
P_LORA_KCT8103L_PA_CTXpin direction getting reset to input afterLoRaFEMControl::init().The string array is enough to fix the ordering so that it doesn't happen (for now), but as a precaution we will also force the pinMode to output before every transmit in case a code change causes ordering to change again.
Investigation is ongoing as to what exactly is resetting the pin direction on
P_LORA_KCT8103L_PA_CTX.