Sensor init: verify chip IDs for INA226 and BME680_BSEC#2746
Open
omeg wants to merge 2 commits into
Open
Conversation
Prevent I2C sensor enumeration from picking up invalid sensors in case of address conflicts. E.g. by default BME680 has the same address as BME280 (0x76). BME680 and other BME sensors check for the correct chip id in begin(), but BME680_BSEC does not. INA260 and INA3221 already check IDs in begin(). INA219 is older and doesn't expose chip ID, it may conflict with other sensors if enabled but not present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent I2C sensor enumeration from picking up invalid sensors in case of address conflicts. E.g. by default BME680 has the same address as BME280 (0x76). BME680 and other BME sensors check for the correct chip id in
begin(), but BME680_BSEC does not.INA260 and INA3221 already check IDs in
begin(). INA219 is older and doesn't expose chip ID, it may conflict with other sensors if enabled but not present. I already had this happen but not sure what to do with it apart from implementing dynamic sensor control via CLI or something.BTW, the reason for this PR was 1.16 enabling BME680_BSEC by default in the RAK4631 variant (which was incorrectly picked up on my device that had a BME280, creating a ghost LPP channel with nothing in it). IMO variant files are not the place for such switches, enables/disables should be controlled in one central place since every device might have different sensors.