revert: "feat: Enable GPS on RAK 1W kit" (#2401)#2536
Merged
Conversation
reverted changes to RAK_BOARD and PIN_GPS_EN. setting `RAK_BOARD` would cause radio to stop working and end with RadioLib error -707
Member
|
Yep, seems like the issue might be when rakGPSinit() is searching for a GPS module it calls gpsIsAwake() against WB_IO2 which is the 5v boost pin on the RAK3401? Maybe some gating here would fix it? |
|
Can we revisit this now that #2615 has been merged? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reverted changes to RAK_BOARD and PIN_GPS_EN. setting
RAK_BOARDwould cause radio to stop working and end with RadioLib error -707