Do not save contacts to FS when nothing has changed #1362
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, on any new contact discovered we would try to write the contacts again. If auto add isn't on, nothing has changed. This can cause corruption by triggering more writes and also reduces flash life.
weebl2000
force-pushed
the
dont-save-autoadd-off
branch
from
1b7db1a to
8fc8bf9
Compare
Contributor
|
Nice work! |
oltaco
approved these changes
Jan 12, 2026
Collaborator
|
@oltaco Do you know if this change still makes senses after your PR (now merged) ? |
Contributor
The idea is still sound but the code will need to be tweaked. I have another PR which I will submit in the next hour that makes another small change to the onAdvertRecv() logic and I will add a change to that so that we only schedule the lazy write when the contacts file has actually changed 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, when auto-add is off and a new contact is discovered this currently triggers a write. That write has no effect, other than reducing flash life and causing more potential corruption.