Repository navigation
feat(profile): log in to the highlighted profile with l, and mark an ended browser login with 💤 - #28
Merged
Merged
Conversation
…ended browser login with 💤 The list of meshstack profile runs meshstack login for the highlighted profile on l, and goes back to the list once the login succeeds. A failed login ends the list with its error. A profile whose browser login session ended, or was logged out, shows 💤 next to 🏠, and auth status and profile show prefix "Session ended" with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Coverage of the acceptance run against the meshStack backend, on
Uncovered functions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
linmeshstack profilerunsmeshstack loginfor the highlighted profile, in process, throughtea.Exec. The list gives up the terminal, so the browser text and the workspace prompt work as usual.auth.BrowserLoginEndedreads only local files and calls no meshStack.auth status/profile showprefix "Session ended" with 💤.How the lock works
The list holds the exclusive profile lock, and the login takes the same lock. So the list releases its lock before the login, and locks and reloads the profiles after a successful one.
run()now releases whatever lock the final model holds, because a login replaces it.cmd/authgetsNewLoginTo(profile), which puts a profile source before the global flags.cmd/profilemay now importcmd/auth(.golangci.yml).Known limits (accepted)
lon an API key or API token profile starts a browser login, which switches the profile's credential, just asmeshstack login -p xdoes.meshstack profilecall (--endpoint,MESHSTACK_ENDPOINT) also apply to the login. A profile for another endpoint then fails, asmeshstack login -p xwould.Tests
TestTheTableMarksTheCurrentProfileAndADialogAsksBeforeItDeletesnow also checks 💤 for a logged-out browser login and thelhelp entry. No unit test pressesl, because that needs a live login. I have not triedlby hand against a meshStack.🤖 Generated with Claude Code