Repository navigation
chore(pluggable-widgets-tools): move shx to devDependencies - #241
Merged
Merged
Conversation
shx is only used by the prepack script, so widget projects do not need it. Moving it to devDependencies stops it, and its transitive shelljs@0.9.2, from being installed in projects that depend on the tools. The direct shelljs@^0.10.0 dependency used by the rollup configs is unchanged.
weirdwater
approved these changes
Oct 29, 2026
weirdwater
left a comment
weirdwater
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good to me.
For crafting I am updating the command tests which removes the dependency from that package. So we can keep it to this for now.
weirdwater
enabled auto-merge
October 29, 2026 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves
shxfromdependenciestodevDependenciesin@mendix/pluggable-widgets-tools, and adds a changelog entry.Why
shxis only used by the package's ownprepackscript (shx rm -rf dist && tsc). Nothing shipped in the package uses it: no rollup config, bin script or generator template. Because it sits independencies, every widget project that installs PWT also getsshx, and through it the outdatedshelljs@0.9.2.PWT also depends directly on
shelljs@^0.10.0(used by the rollup configs). That stays. After this change, consumers get onlyshelljs@0.10.x.Verification
pnpm-lock.yamldiff only movesshxbetween importer sections. No other packages change.pnpm lint:changelogandpnpm testpass inpackages/pluggable-widgets-tools(83 tests).pnpm packrunsprepacksuccessfully. The packedpackage.jsonhasshxonly indevDependencies.Alternative worth considering
Removing
shxcompletely and replacing the script with a one-liner would drop two more dependencies from the repo (shxandshelljs@0.9.2in the lockfile), for example:packages/command-testsalso listsshx, but nothing there uses it, so it could be removed at the same time. I kept this PR to the smaller change. If the team prefers the full removal, I can update the PR.