Skip to content

fix: combobox e2e failure #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gjulivan merged 1 commit into from
Oct 22, 2026
Merged

fix: combobox e2e failure #2488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/pluggableWidgets/combobox-web/e2e/Combobox.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ test.describe("combobox-web", () => {
await expect(comboBox).toHaveScreenshot(`comboBoxAssociationRowClick.png`);
await comboBox.click();
await expect(page.locator(".modal-body .mx-name-layoutGrid1").first()).toHaveScreenshot(
`comboBoxAssociationRowClickOpen.png`
`comboBoxAssociationRowClickOpen.png`,
{ maxDiffPixels: 10 }
);
});

Expand Down Expand Up @@ -97,7 +98,8 @@ test.describe("combobox-web", () => {
await comboBox.click();
await getFilterInput(comboBox).fill("A");
await expect(page.locator(".modal-body .mx-name-layoutGrid1").first()).toHaveScreenshot(
`comboBoxFiltering.png`
`comboBoxFiltering.png`,
{ maxDiffPixels: 10 }
);
});

Expand Down
8 changes: 6 additions & 2 deletions packages/pluggableWidgets/combobox-web/e2e/OnChange.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,12 @@ test.describe("combobox-web onChange", () => {
await combobox.selectOption("Multi Option nr.1");
await combobox.selectOption("Multi Option nr.2");

const entries = await getLogs(page);
expect(entries[entries.length - 1].multiAssocTitles).toEqual(["Multi Option nr.1", "Multi Option nr.2"]);
await expect
.poll(async () => {
const entries = await getLogs(page);
return entries[entries.length - 1]?.multiAssocTitles;
})
.toEqual(["Multi Option nr.1", "Multi Option nr.2"]);
});
});

Expand Down
Loading