Skip to content

[WC-3485]: fix(app-events-web): remove unexpected spacing caused by widget styles#2306

Open
r0b1n wants to merge 1 commit into
mainfrom
fix/app-events-web-unexpected-spacing
Open

[WC-3485]: fix(app-events-web): remove unexpected spacing caused by widget styles#2306
r0b1n wants to merge 1 commit into
mainfrom
fix/app-events-web-unexpected-spacing

Conversation

@r0b1n

@r0b1n r0b1n commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The widget-events class had flex-grow: 1, position: relative, and transition styles that caused the widget div to occupy space in flex layouts at runtime
  • Since App Events is a purely logical widget with no visual content, it should be hidden (display: none)
  • Removed the leftover styles and replaced with display: none

Test plan

  • Place an App Events widget inside a flex container in Studio Pro and verify no unexpected spacing appears
  • Verify the widget still fires events correctly (no visual regression expected — widget renders nothing)

@r0b1n r0b1n requested a review from a team as a code owner July 6, 2026 07:35
@github-actions

This comment has been minimized.

@r0b1n r0b1n changed the title fix(app-events-web): remove unexpected spacing caused by widget styles [WC-3485]: fix(app-events-web): remove unexpected spacing caused by widget styles Jul 6, 2026
The widget-events class had flex-grow and positioning styles that caused
unwanted spacing in flex container layouts at runtime. Since the widget
renders no visible content, it should not occupy any space.
@r0b1n r0b1n force-pushed the fix/app-events-web-unexpected-spacing branch from f72e046 to 6b2b1eb Compare July 6, 2026 07:41
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found


What was reviewed

File Change
packages/pluggableWidgets/events-web/src/ui/Events.scss Removed leftover flex/positioning/transition styles; replaced with display: none
packages/pluggableWidgets/events-web/CHANGELOG.md Added [Unreleased] / Fixed entry describing the layout fix

Skipped (out of scope): dist/, pnpm-lock.yaml

All CI checks were not retrievable (permission restricted), but the change is purely a CSS/CHANGELOG edit with no logic or test impact.


Positives

  • Correct diagnosis: display: none is the right approach for a purely logical, zero-visual widget — it removes it from all layout algorithms (flex, grid, block flow) rather than just hiding it visually.
  • The removed SCSS variables ($brand-primary, $gray-dark) were unused in the file — good cleanup without side effects.
  • CHANGELOG entry is user-facing and follows the repo's "widget behavior, not implementation details" convention, placed correctly under [Unreleased] / Fixed.
  • PR title follows the [WC-XXXX]: type(scope): description convention and the test plan covers both the visual (no spacing) and functional (events still fire) cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants