Skip to content

[WC-3460]: FileUploader pre-release QA & decision review#2269

Open
yordan-st wants to merge 4 commits into
mainfrom
fix/WC-3460_fileuploader-qa-review
Open

[WC-3460]: FileUploader pre-release QA & decision review#2269
yordan-st wants to merge 4 commits into
mainfrom
fix/WC-3460_fileuploader-qa-review

Conversation

@yordan-st

@yordan-st yordan-st commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Pull request type

Bug fix (non-breaking change which fixes an issue)

Description

Pre-release QA and decision review for file-uploader-web covering changes introduced by WC-3361 (upload queue, concurrent upload limit, total file limit feedback, retry for over-limit files, list ordering) and WC-3363 (dismiss for invalid-format rejections, yellow warning lifecycle).

Two bugs found and fixed:

  • sortedFiles was only pushing validationError entries to the end of the list; rejected (over-limit) files were sorting alongside successful uploads. Fixed to push both validationError and rejected below all other entries.
  • Invalid-format drops produced per-entry error messages but no yellow warning banner on the dropzone. Fixed by wiring the new hasValidationErrors computed into FileUploaderRoot warningMessage logic — banner appears when validationError files are present and clears when all are dismissed.

What should be covered while testing?

File limit feedback

  • Set maxFilesPerUpload = 3. Drop 3 files → dropzone greys out + "Maximum file count of 3 reached." message appears
  • While at limit, remove one uploaded file → dropzone re-enables, message disappears
  • Set maxFilesPerUpload = 0 or leave empty → dropzone never disables, no message ever shown

Upload queue

  • Set maxFilesPerBatch = 2. Drop 5 files → exactly 2 show "Uploading…", remaining 3 show "Waiting…" with no progress bar
  • One upload completes → next queued file auto-starts (now 2 uploading again)
  • Leave maxFilesPerBatch empty → all dropped files start uploading simultaneously
  • Simulate upload error (network off) → that slot frees up, next queued file starts automatically

Retry for over-limit rejections

  • Set maxFilesPerUpload = 2. Drop 4 files → 2 upload, 2 appear as rejected with retry button greyed out
  • Remove one uploaded file → retry button on one rejected file becomes enabled
  • Click retry → that file starts uploading; remaining rejected files still show greyed retry
  • Upload failure does NOT auto-promote remaining queued or rejected files

Dismiss for invalid-format rejections

  • Configure allowed formats (e.g. PDF only). Drop an unsupported file → yellow warning appears on dropzone + rejected entry with ✕ button
  • Click ✕ on the entry → entry removed, yellow warning clears
  • Drop 2 unsupported files → dismiss one → yellow warning still visible; dismiss the second → warning clears
  • Drop an invalid file, then drop a valid file → previous invalid entry clears immediately, yellow warning clears on drop

List ordering

  • Mixed session (some uploaded, some rejected/invalid) → successful files always render above rejected and invalid entries

Regression checks

  • Set readOnlyMode = true → dropzone is not rendered, no errors
  • Switch uploadMode to images → queue, limit, and dismiss behavior works identically to files mode
  • Upload without any limits configured → no regressions in standard upload flow

@yordan-st yordan-st force-pushed the fix/WC-3460_fileuploader-qa-review branch from 75a2ada to 3f56f19 Compare June 16, 2026 14:09
@yordan-st yordan-st marked this pull request as ready for review June 16, 2026 14:10
@yordan-st yordan-st requested a review from a team as a code owner June 16, 2026 14:10
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant