[MOO-2069] : Signature widget update for 11-12 - #607
Open
saurabhchavan1711 wants to merge 7 commits into
Open
Conversation
stelselim
previously approved these changes
Sep 2, 2026
Contributor
|
Please check my comments on #499 |
YogendraShelke
approved these changes
Sep 3, 2026
MxKevinBeqo
requested changes
Sep 7, 2026
| **Key Changes:** | ||
|
|
||
| 1. The widget now saves the signature directly to an entity that generalizes `System.Image`, instead of storing a base64-encoded string in a String attribute and then converting it to Image. | ||
| 2. The **On save** event has been renamed to **On sign end** under the **Events** tab. |
Contributor
There was a problem hiding this comment.
Unless absolutely required by some external factor or rule:
I would suggest we keep the same display name for this attribute because for the customer the purpose of the attribute does not change i.e. "what to trigger when clicking the Save button".
The renamed attribute also might bring confusion, because it sounds like "what happens when you end/finish the signing drawing".
|
|
||
| ### Added | ||
|
|
||
| - Added direct image upload to System.Image object using the type `image` with `allowUpload` set to true. |
Contributor
There was a problem hiding this comment.
Since this is a breaking change, I would prefix this note with a [BREAKING] or something similar, and add a mention for the corresponding README section for quick-reference to the nice migration you prepared 🙌 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅Feature specific
This PR contains
What is the purpose of this PR?
The PR introduces a new option in the signature widget of saving signature directly as a image . In the existing flow , signature's base64 string needs to be store in attribute of entity . Then end user has to create a nanoflow , use base64decodetoimage jsaction to convert this base64 to blob and then upload signature which is a overhead and is error prone . With this new option everything is taken care under the hood and user don't really need to store value to attribute then user base64decodetoimage jsaction. With this change the signature widget feels more a like end to end .
Added migration document and its related images as per suggestion of Docs team
What should be covered while testing?