Skip to content

ci(test-lanes): run every package whose suites read every workflow on a workflow change #13925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyle-sexton merged 3 commits into from
Nov 7, 2026
+28 −12
Merged

ci(test-lanes): run every package whose suites read every workflow on a workflow change #13925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c6b572
ci(test-lanes): run every package whose suites read every workflow on…
kyle-sexton Nov 7, 2026
5923b3a
Merge branch 'main' into fix/select-tests-workflow-readers
kyle-sexton Nov 7, 2026
6a390d5
Address review feedback on fix/select-tests-workflow-readers
melodic-automation-lanes[bot] Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions scripts/plan-test-lanes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ plugins/miro/server plugins/miro/
plugins/ai-briefing/skills/generate/output/build plugins/ai-briefing/skills/generate/ plugins/ai-briefing/skills/generate/scripts/run-tests.sh
plugins/knowledge/skills/video-digest/extraction plugins/knowledge/skills/video-digest/ plugins/knowledge/skills/video-digest/scripts/run-tests.sh plugins/knowledge/vendor/node-launcher/ plugins/knowledge/scripts/
plugins/knowledge/skills/course-digest/extraction plugins/knowledge/skills/course-digest/ plugins/knowledge/skills/course-digest/scripts/run-tests.sh plugins/knowledge/vendor/node-launcher/ plugins/knowledge/scripts/
.github/actions/resolve-config .github/actions/resolve-config/ .github/actions/seal-lane-output/ .github/actions/open-lane-output/ .github/lane-keys/ docs/conventions/pr-pipeline/ docs/conventions/pr-pipeline.yaml .github/scripts/pr-unblock/feedback-dispatch.mjs .github/scripts/pr-unblock/fix-ci-context.mjs"
.github/actions/resolve-config .github/actions/resolve-config/ .github/actions/seal-lane-output/ .github/actions/open-lane-output/ .github/lane-keys/ docs/conventions/pr-pipeline/ docs/conventions/pr-pipeline.yaml .github/scripts/pr-unblock/feedback-dispatch.mjs .github/scripts/pr-unblock/fix-ci-context.mjs .github/workflows/"

usage() {
awk 'NR == 1 { next } /^#/ { sub(/^# ?/, ""); print; next } { exit }' "${BASH_SOURCE[0]}" >&2
Expand Down Expand Up @@ -223,8 +223,15 @@ read_list::into exclusions "$EXCLUSIONS_LIST" --comments inline || exit 2
read_list::into outside "$PACKAGES_LIST" --comments inline || exit 2

# Triggers beyond its own directory for a package in the outside list: the
# workflows and shared files its tests read.
# workflows and shared files its tests read. A suite that lists
# .github/workflows/ names no workflow, so the selector never reaches it from
# one; its package takes the whole directory as a trigger.
declare -A OUTSIDE_TRIGGERS=(
[.github/actions/check-signed-commits]=".github/workflows/"
[.github/actions/check-wip-cap]=".github/workflows/"
[.github/actions/log-api-budget]=".github/workflows/"
[.github/scripts/lib]=".github/workflows/"
[.github/scripts/pr-merge]=".github/workflows/"
[.github/scripts/pr-verify]=".github/workflows/pr-verify.yml .github/workflows/pr-verify-capture.yml .github/scripts/lib/"
[.github/scripts/lane-run-report]=".github/workflows/pr-run-activity-read.yml .github/workflows/pr-run-activity-write.yml .github/scripts/lib/"
[.github/scripts/pr-run-activity-read]=".github/workflows/pr-run-activity-read.yml .github/scripts/lib/"
Expand Down
29 changes: 19 additions & 10 deletions scripts/plan-test-lanes.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ ERR="$scratch/plan.err"

cp "$REPO_ROOT/scripts/affected-tests-no-suite.txt" "$repo/scripts/"
: >"$repo/scripts/run-plugin-tests-serial.txt"
printf 'plugins/knowledge/vendor/repo-analysis\n.github/scripts/pr-verify\nscripts/lane-transcripts\n' >"$repo/scripts/outside-node-packages.txt"
printf '%s\n' plugins/knowledge/vendor/repo-analysis .github/actions/check-signed-commits .github/actions/check-wip-cap \
.github/actions/log-api-budget .github/scripts/lib .github/scripts/pr-merge .github/scripts/pr-verify \
scripts/lane-transcripts >"$repo/scripts/outside-node-packages.txt"
printf 'plugins/fx/evals/fixtures/\n' >"$repo/scripts/outside-node-exclusions.txt"

# mk <path> [<content>]: a fixture file.
Expand Down Expand Up @@ -314,26 +316,33 @@ rc=0
[[ " $(key node_packages) " != *" .github/actions/resolve-config "* ]] || rc=1
check "a sibling of a trigger file does not run that package" "$rc"

# The packages with a suite that lists .github/workflows/ and reads every file
# in it, so no workflow's name reaches them: callers.test.mjs and
# api-budget-coverage.test.mjs (resolve-config), check-signed-commits.test.mjs,
# check-wip-cap.test.mjs, log-api-budget.test.mjs, handoff-evidence.test.mjs
# (lib), pr-merge's workflow.test.mjs and lane-transcripts' pull.test.mjs.
EVERY_WORKFLOW=".github/actions/resolve-config .github/actions/check-signed-commits .github/actions/check-wip-cap \
.github/actions/log-api-budget .github/scripts/lib .github/scripts/pr-merge scripts/lane-transcripts"

plan -- .github/workflows/pr-verify.yml
is "$(key node_packages)" ".github/scripts/pr-verify scripts/lane-transcripts" && is "$(key node)" true
is "$(key node_packages)" "${EVERY_WORKFLOW% *} .github/scripts/pr-verify scripts/lane-transcripts" && is "$(key node)" true
check "a change to pr-verify.yml alone runs the pr-verify package" $?

plan -- .github/workflows/pr-unblock.yml
rc=0
[[ " $(key node_packages) " != *" .github/scripts/pr-verify "* ]] || rc=1
check "another workflow does not run the pr-verify package" "$rc"

# pull.test.mjs reads every workflow's upload-lane-transcript calls.
is "$(key node_packages)" "scripts/lane-transcripts"
check "any workflow change runs the lane-transcripts package" $?
plan -- .github/workflows/new-uploader.yml
is "$(key node_packages)" "$EVERY_WORKFLOW" && is "$(key node)" true
check "a workflow no suite names runs every package whose suites read every workflow" $?

plan -- .github/actions/check-kill-switch/action.yml
rc=0
[[ " $(key node_packages) " != *" scripts/lane-transcripts "* ]] || rc=1
check "a change outside .github/workflows/ does not run the lane-transcripts package" "$rc"
is "$(key node_packages)" "" && is "$(key node)" false
check "a change outside .github/workflows/ runs none of the packages that read every workflow" $?

plan -- .node-version
is "$(key node_packages | wc -w | tr -d ' ')" 8
is "$(key node_packages | wc -w | tr -d ' ')" 13
check "a Node pin runs every Node package" $?

plan -- plugins/ps/x.ps1
Expand Down Expand Up @@ -371,7 +380,7 @@ check "an unmapped shell file runs the whole shell corpus and is counted" $?

plan -- .github/workflows/pr-require-checks.yml
is "$(key bash_legs)" "[0,1,2,3,4,5,6,7,8,9,10,11]" && is "$(suites bash | wc -l | tr -d ' ')" 12 &&
is "$(suites python | wc -l | tr -d ' ')" 2 && is "$(key node_packages | wc -w | tr -d ' ')" 8 &&
is "$(suites python | wc -l | tr -d ' ')" 2 && is "$(key node_packages | wc -w | tr -d ' ')" 13 &&
is "$(key windows_jobs)" "[]"
check "a pr-require-checks.yml change runs every pr-require-checks.yml lane whole on 12 legs, and test-windows from the selection" $?

Expand Down
Loading