Skip to content

fix(lane-transcripts): list the mutation lane's transcript uploads in the puller - #13641

Merged
kyle-sexton merged 1 commit into
mainfrom
fix/lane-transcripts-mutation-list
Nov 6, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
fix/lane-transcripts-mutation-list

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: main fails test-node since the mutation-lane change; this unblocks the merge queue

Summary

Since #13632 moved the post-merge mutation lane onto run-claude-cli, post-merge-test-mutation.yml uploads a lane transcript from six jobs. The transcript puller's TRANSCRIPT_JOB_IDS did not list that workflow. So scripts/lane-transcripts/pull.test.mjs, which checks that every uploading workflow is listed, fails on main, and the merge queue drops every pull request. #13631 was removed for failed_checks in merge-group run 42147891790.

Fix

Add post-merge-test-mutation.yml to TRANSCRIPT_JOB_IDS with its six upload job-ids: generate and triage, each with its -subscription and -fallback legs (legs("generate"), legs("triage")). Each upload passes job-id: ${{ github.job }}.

Verification

  • Before: run 42147891790, test-node, ✖ every workflow that uploads a lane transcript, and every job-id it passes, is in the puller's list. The actual list had post-merge-test-mutation.yml and the expected list did not.
  • After: node --test scripts/lane-transcripts/*.test.mjs 32/32 pass.

Related

🤖 Generated with Claude Code

… the puller

post-merge-test-mutation.yml uploads a lane transcript from its generate
and triage jobs and their subscription and fallback legs since #13632,
so pull.test.mjs's upload-coverage test fails on main and the merge queue
drops every pull request. Add the six job-ids to TRANSCRIPT_JOB_IDS.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 6, 2026 02:28
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-06T02:28:30.229278Z
We couldn’t complete this review. Comment @codex review to try again.
e511a42 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

claude-security-review reviewed e511a42210e9e16ccf928bc61960e0227bec83da: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #13641

No security issues found.

What changed: one line in scripts/lane-transcripts/pull.mjs. It adds post-merge-test-mutation.yml to TRANSCRIPT_JOB_IDS, using the six job IDs from legs("generate") and legs("triage"). The PR description says this matches the transcript uploads that #13632 added.

What I checked:

  • What the list controls. TRANSCRIPT_NAMES is built from this list (pull.mjs#L83). It sets which lane-transcript-<id>-<n> artifact names the operator-side puller lists and downloads from this repository's own Actions artifacts.
  • No new trust or exposure. The new names point only at sealed artifacts from a workflow in the same repository. The existing size cap, single-entry sealed-record check, and dedupe in store/sealedRecord are unchanged.
  • Nothing reaches a credentialed lane. No token scope, trusted actor, kill switch or merge hold is touched. No untrusted text is newly routed to a lane that holds credentials.
  • Path rules. The file matches none of the listed trusted-path globs and is not a trust control under the skill's definition.

No plugin manifest, instruction surface or Actions workflow is changed.

This was a full review of the head, not a blocking-only pass. No prior findings from this lane.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

claude-review reviewed e511a42210e9e16ccf928bc61960e0227bec83da: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review: clean, no findings.

This PR adds one line to scripts/lane-transcripts/pull.mjs. It lists the job-ids that post-merge-test-mutation.yml uploads transcripts under, so the puller reads them and the coverage test in pull.test.mjs stops failing on main.

What I checked:

  • The job-ids match the workflow. legs("generate") and legs("triage") produce generate, generate-subscription, generate-fallback, triage, triage-subscription and triage-fallback. Those are the six jobs in .github/workflows/post-merge-test-mutation.yml with an upload step passing job-id: ${{ github.job }}: the jobs at lines 223, 547, 839, 1283, 1636 and 1957, with the uploads at lines 425, 753, 1039, 1514, 1871 and 2186.
  • No name collisions. No other workflow in TRANSCRIPT_JOB_IDS uses generate or triage, so the new artifact names (lane-transcript-<job-id>-<attempt>) don't clash with existing ones. TRANSCRIPT_NAMES dedups names anyway.
  • Lane labels are unaffected. laneOf takes the lane from the workflow file name, not the job-id.
  • Listing budget is fine. The change adds 18 names (6 job-ids × 3 attempts). MAX_LIST_CALLS is derived from the name count, so it grows with them, and the 400 floor still applies.

Not verified: the PR's "32/32 pass" result for node --test scripts/lane-transcripts/*.test.mjs is the author's claim. I had no shell, so I didn't run the tests.

Scope notes:

  • The PR names no closing issue, so there are no acceptance criteria to check.
  • No plugin manifest changed and no .claude/rules path rule applies.
  • The changed file matches no trusted-path glob.
  • I found no embedded instructions in the PR context.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 654f196 Nov 6, 2026
67 of 68 checks passed
@kyle-sexton
kyle-sexton deleted the fix/lane-transcripts-mutation-list branch November 6, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant