Skip to content

chore(review): drop the one-release review-digest team fallbacks #13556

Description

@kyle-sexton

Refs #5906

Outcome

/review:explain-change reads its team settings only from docs/conventions/review-digest.yaml. The one-release fallbacks to the ```json config block in docs/conventions/review-digest.md and to .claude/review-digest.json are gone. The YAML reader shipped with "read only when the YAML file is absent from the base commit, for one release" (plugins/review/CHANGELOG.md:694), and the plugin is at 7.4.0 now. #5906's verify run on 2026-11-05 parked it with this item unmet (its outcome=parked comment). The user-global ~/.claude/review-digest.json and the personal .claude/review-digest.local.json layers stay.

Change

  • plugins/review/skills/explain-change/scripts/digest-policy.mjs:
    • readTeamDigest (:205-241, called at :262) takes the team layer from docs/conventions/review-digest.yaml only.
    • Delete configBlock (:125-148); its only caller is the fallback at :219.
    • Drop the docs/conventions/review-digest.md and .claude/review-digest.json entries from the team-file list (:251) and from the readTeamDigest call (:262).
    • Remove docs/conventions/review-digest.md (:40) and .claude/review-digest.json (:41) from CONFIG_PATHS, since neither is read any more.
    • Keep .claude/review-digest.local.json (:42) and the user-global review-digest.json filename (:250).
  • docs/conventions/review-digest.md: remove the ```json config block and its note (:85-98), and rewrite list item 2 (:54-57) to say the team layer is docs/conventions/review-digest.yaml only.
  • docs/contracts/config-cascade/README.md:595 and :673: describe the review-digest team layer as the YAML file only, and drop the "old pair" and ADR 0044 sentences in those rows.
  • plugins/review/tests/explain-change.test.mjs:
    • Remove the configBlock import (:31), its describe (:179-191), and the block comparison at :198-199.
    • Rewrite the cases at :226-238, :298-309, :343-349 and :383-389 to use the YAML file, with review-digest.yaml as the risk-path witness path at :389.
    • Add assertions that a tracked docs/conventions/review-digest.md json-config block and a tracked .claude/review-digest.json are not read.
  • Add a review changelog fragment.

Done when

  • git grep -n 'claude/review-digest\.json' -- plugins/review/skills/explain-change/scripts/digest-policy.mjs prints nothing (3 lines on origin/main today: :41, :251, :262).
  • git grep -n 'json config' -- docs/conventions/review-digest.md plugins/review/skills/explain-change/scripts/digest-policy.mjs prints nothing (4 lines today: review-digest.md:55 and :89, digest-policy.mjs:125 and :140).
  • git grep -n 'review-digest.json' -- docs/contracts/config-cascade/README.md prints nothing (:595 and :673 today).
  • node --test plugins/review/tests/explain-change.test.mjs passes in the PR's CI.
  • scripts/check-changelog-fragments.sh --check-required origin/main exits 0.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 5, 2026
  2. github-actions commented on Nov 5, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Medium
    Complexity: Low
    Uncertainty: Known
    Flags: none
    Blocked by: none

    Understood: remove the one-release fallbacks so /review:explain-change reads its team digest settings only from docs/conventions/review-digest.yaml. The change covers digest-policy.mjs, the convention doc, the config-cascade README rows, the tests and a changelog fragment. The done-when checks are exact and the approach is clear, so nothing is missing. I found no duplicate among the open issues.

    Automated triage, applied by the lanes App.

  3. added
    priority: mediumReal value, no hard deadline; normal backlog flow.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 5, 2026
  4. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.
    on Nov 5, 2026
  5. added
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    admission-deferredAdmitted but waiting for WIP room; the hourly work-unblock sweep labels it agent-ready.
    on Nov 5, 2026
  6. github-actions commented on Nov 5, 2026

    @github-actions
    Contributor
    No description provided.
  7. github-actions commented on Nov 5, 2026

    @github-actions
    Contributor
    No description provided.
  8. melodic-automation-lanes commented on Nov 5, 2026

    @melodic-automation-lanes
    Contributor

    The work-resolve-issue run that agent-ready started waited in its slot past a change to its lane workflow files on main, so it stopped before any model turn. The run's report-outcome removed and added agent-ready back to start a fresh run on main's workflow files. If this run ends the same way, it re-fires the issue again, waiting longer each time.

  9. added
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    and removed
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 5, 2026
  10. github-actions commented on Nov 5, 2026

    @github-actions
    Contributor
    No description provided.
  11. github-actions commented on Nov 5, 2026

    @github-actions
    Contributor
    No description provided.
  12. removed
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.
    on Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: mediumReal value, no hard deadline; normal backlog flow.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Type

    Fields

    Work status

    agent-ready

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions