Repository navigation
ci(lanes): hand an empty subscription token to the fallback leg - #995
Conversation
intake-triage.yml and pr-review-cli.yml ran their fallback leg only on the subscription leg's handoff, so an empty subscription token stopped the lane even with FALLBACK_CLAUDE_CODE_OAUTH_TOKEN set. The fallback job now also starts when the subscription job's credential-present is false and its fallback-ready is true, the same rule an empty key follows to the subscription leg, and its lane record names fallback reason no-key. With every token empty nothing new starts. Refs: melodic-software/claude-code-plugins#13586 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Incremental review of 422abd9, covering The change only reflows long
I did not run the tests; this verdict comes from reading the diff. I also did not check the formatting against biome. The PR context, settled-threads and prior-findings files were not needed for a formatting-only change. |
|
claude-security-review reviewed Incremental review of 422abd9, covering the changes since 899c0ec in No security findings. Both changes only reformat existing critical-findings: 0 |
Refs: melodic-software/claude-code-plugins#13586 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs: melodic-software/claude-code-plugins#13586
Summary
Before this change, an empty subscription token in either reusable stopped the lane, even when
FALLBACK_CLAUDE_CODE_OAUTH_TOKENwas set. Now both reusables hand that case to the fallback leg, the same rule an empty key already follows to the subscription leg. The owner asked for this as part of making the lanes "consistent and uniform" (#13586). The claude-code-plugins lanes already follow it (#13590, #13608).Fix
intake-triage.yml:fallback-ready.fallbackjob starts onhandoff == 'true', or oncredential-present == 'false' && fallback-ready == 'true'.no-key.pr-review-cli.yml: the same change forreview-fallback.statusand record logic report it as before.Verification
node --test .github/scripts/*.test.cjs: 912 tests, 912 pass.intake-triage-legs.test.cjsandpr-review-cli.test.cjs. An empty subscription token with the fallback token set starts the fallback leg. Without the fallback token, or with no credential check at all, it does not. The leg recordsno-key.zizmor --offline: no findings.actionlintreports only the existing$/self-reference format.Related
check-key-creditgate forintake-triage.yml.pr-review-cli.ymlalready has it. Every caller pinsintake-triage.yml@mainand grants noactions: read, so a gate job added here would break those callers the moment this merges. The callers have to addactions: readfirst.🤖 Generated with Claude Code