Update bootstrap-hover-dropdown for Bootstrap 5#165
Open
derek-ye wants to merge 1 commit intomdbootstrap:masterfrom
Open
Update bootstrap-hover-dropdown for Bootstrap 5#165derek-ye wants to merge 1 commit intomdbootstrap:masterfrom
derek-ye wants to merge 1 commit intomdbootstrap:masterfrom
Conversation
derek-ye
commented
Aug 10, 2021
- Updated '.open' with '.show' because '.open' deprecated in BS5 (https://getbootstrap.com/docs/5.0/components/dropdowns/#usage)
jrchamp
reviewed
Aug 11, 2021
Contributor
There was a problem hiding this comment.
This adds compatibility for Bootstrap 5, but does this break backwards compatibility with any previous versions of Bootstrap that are currently supported? And by that I mean, "work with bootstrap-hover-dropdown". I do not mean "supported by Twitter".
Comment on lines
+11
to
+15
|
|
||
|
|
||
| */ | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Looks like some blank lines snuck in!
Suggested change
| */ | |
| */ |
|
Maybe I have something misconfigured in my project, but I had to change line 119 to: $parent.children(".dropdown-menu").addClass('show');to make this work with Bootstrap 5. And also I changed line 50 to: if(!$parent.hasClass('show') && !($this.is(event.target) || $parent.is(event.target))) {otherwise the hover action was unreliable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.